Theia runs save on app startup if "editor.autoSave": "on" is configured in the settings.json

[kittaakos]

When I have the following settings.json in my workspace and the app starts, a save event will be fired from the editor commands:

settings.json:

{
  "editor.autoSave": "on"
}

theia/packages/editor/src/browser/editor-command.ts

Lines 171 to 175 in d660747

	this.editorPreferences.onPreferenceChanged(e => {
	if (e.preferenceName === 'editor.autoSave' && e.newValue === 'on') {
	this.shell.saveAll();
	}
	});

Theia incorrectly assumes there was a preference change, but there wasn't. Auto-save is enabled by default, so I would expect the exact same behavior when I have an empty settings.json or one with "editor.autoSave": "on".

Steps to Reproduce:

Additional Information

• Operating System:
• Theia Version:

[kittaakos]

This PR causes the undesired side effect.

[kittaakos]

Nice, the default auto-save preference is off:

theia/packages/editor/src/browser/editor-preferences.ts

Line 1246 in d660747

'default': 'off',

But editor command ignores this and assumes auto-save if on when not set:

theia/packages/editor/src/browser/editor-command.ts

Line 333 in d660747

return autoSave === 'on' || autoSave === undefined;

[kittaakos]

Here is a workaround for the time being:

your-module.ts:

bind(EditorCommandContribution).toSelf().inSingletonScope();
rebind(TheiaEditorCommandContribution).toService(EditorCommandContribution);

your-editor-commands.ts:

import { injectable, postConstruct } from 'inversify';
import { EditorCommandContribution as TheiaEditorCommandContribution } from '@theia/editor/lib/browser/editor-command';

@injectable()
export class EditorCommandContribution extends TheiaEditorCommandContribution {

    @postConstruct()
    protected init(): void {
        // Workaround for https://github.com/eclipse-theia/theia/issues/8722.
        this.editorPreferences.onPreferenceChanged(({ preferenceName, newValue, oldValue }) => {
            if (preferenceName === 'editor.autoSave') {
                const autoSaveWasOnBeforeChange = !oldValue || oldValue === 'on';
                const autoSaveIsOnAfterChange = !newValue || newValue === 'on';
                if (!autoSaveWasOnBeforeChange && autoSaveIsOnAfterChange) {
                    this.shell.saveAll();
                }
            }
        });
    }

}