[git] Selected git repository does not get updated on repository deletion

[kittaakos]

This is a follow up of #899.

Let assume you have repository A, B in your workspace and repository A is selected in the drop-down in the Git tab. Lose the focus from the Git tab (select Files or you name it), delete repository A outside from Theia. Activate the Git tab, repository A is still selected as the active one.

Expected:
B should be selected, A should not be among the repositories.

This glitch does not cause any problem, the git watcher was gracefully disposed. One has to refresh the view manually.

[kittaakos]

This could be invalid after #1091. I look into this task.

[kittaakos]

I can confirm, the issue is still present. The frontend does not receive any notification if the repository gets removed from the workspace. The active repository is still the deleted one. It used to work before #899.

[kittaakos]

It used to work before #899.

No. Way before this... I think it never made it to the master. See the removal here.

[kittaakos]

@svenefftinge, @akosyakov; shall we treat this behavior as a bug or a missing feature?

I would expect that the UI (frontend state) gets updated after a repository deletion but adding this could be costly performance wise. We could detect if a .git folder was deleted from the WS, but that point we cannot check whether it was a repository or not. So we would need to maintain some state on the backend.

[svenefftinge]

We can categorize it as a bug. Low priority, though, because it doesn't have bad implications and is a rare corner-case.

[westbury]

I've just tested this with PR #3831 and it appears to be fixed. Delete repository A and I see the Git view and the status bar indicator automatically switch to repository B.

[vince-fugnitto]

I've just tested this with PR #3831 and it appears to be fixed. Delete repository A and I see the Git view and the status bar indicator automatically switch to repository B.

I tested it as well and it works correctly.

I started with a workspace that contained the folders a, b which each had repositories.
When starting the app we get the first repo a. If a is deleted from outside of the app, the SCM widget and corresponding repo statusbar item is updated to b.

I'll close the issue as it's been resolved, and will re-open it in the future if the problem returns.