Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editors are not reopened after restart when using Electron example #943

Closed
MarkZ3 opened this issue Dec 4, 2017 · 5 comments
Closed

Editors are not reopened after restart when using Electron example #943

MarkZ3 opened this issue Dec 4, 2017 · 5 comments

Comments

@MarkZ3
Copy link
Contributor

MarkZ3 commented Dec 4, 2017

Using master as of commit 9f60988

  1. Start the Electron app from examples/electron, with 'yarn run start'
  2. Open a file
  3. Close windows and terminate the backend (Ctrl+C)
  4. Re-run 'yarn run start': editor is not reopened.

This seems to work fine in the browser version.

@MarkZ3
Copy link
Contributor Author

MarkZ3 commented Dec 4, 2017

I should add, doing "Reset workbench layout" did not fix it.

@hexa00
Copy link

hexa00 commented Dec 5, 2017

Confirmed.

The editors seems to be saved properly however I see in the Local Data:

"{\"mainArea\":{\"activeWidgets\":[{\"constructionOptions\":{\"factoryId\":\"code-editor-opener\",\"options\":\"file:///home/eantotr/src/theia/CONTRIBUTING.md\"}}],
\"main\":{\"type\":\"tab-area\",\"widgets\":[{\"constructionOptions\":{\"factoryId\":\"code-editor-opener\",\"options\":\"file:///home/eantotr/src/theia/CODE_OF_CONDUCT.md\"}},{\"constructionOptions\":{\"factoryId\":\"code-editor-opener\",\"options\":\"file:///home/eantotr/src/theia/CONTRIBUTING.md\"}}],\"currentIndex\":1}},\"leftBar\":{\"activeWidgets\":[{\"constructionOptions\"

Must be something with the restore...

@hexa00
Copy link

hexa00 commented Dec 5, 2017

@svenefftinge This is because now we store per location and that electron is using dynamic port allocation so since #905 the electron app restore is broken...

@svenefftinge
Copy link
Contributor

I reverted it 49a86f3

@MarkZ3
Copy link
Contributor Author

MarkZ3 commented Dec 5, 2017

works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants