Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-view: enable tree search and filtering for trees contributed by plugins #9533

Closed
idoprz opened this issue May 30, 2021 · 4 comments · Fixed by #9703
Closed

tree-view: enable tree search and filtering for trees contributed by plugins #9533

idoprz opened this issue May 30, 2021 · 4 comments · Fixed by #9703
Labels
tree issues related to the tree (ex: tree widget) vscode issues related to VSCode compatibility

Comments

@idoprz
Copy link

idoprz commented May 30, 2021

Bug Description:

The goal is to enable searching and filtering in contributed tree-views when typing similarly to trees contributed by the framework (ex: explorer, scm, outline). The tree search and filtering is supported in vscode, and should be supported by tree-views contributed by plugins as well.

Steps to Reproduce:

  1. start the application
  2. open the explorer, and ensure that npm scripts tree-view part is visible
  3. attempt to search in it by typing - nothing occurs
  4. attempt the same use-case in vscode - tree search and filtering is supported

Additional Information

  • Operating System: all
  • Theia Version:
@vince-fugnitto vince-fugnitto added 🤔 needs more info issues that require more info from the author tree issues related to the tree (ex: tree widget) labels May 31, 2021
@vince-fugnitto
Copy link
Member

@idoprz can you clarify which tree(s) you were expecting the filtering for?
The filtering occurs for the following trees as part of the application (corresponding review):

  • explorer
  • scm
  • outline

@idoprz
Copy link
Author

idoprz commented Jun 2, 2021

Hi,
I mean on trees from extensions. Right now it only works for the "build in extensions" as you said explorer, scm, outline.
On VSCode the filter works for extensions trees as well.

@vince-fugnitto vince-fugnitto changed the title filter on trees tree-view: enable tree search and filtering for trees contributed by plugins Jun 2, 2021
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility and removed 🤔 needs more info issues that require more info from the author labels Jun 2, 2021
@vince-fugnitto
Copy link
Member

@idoprz I took the liberty of updating the title and description and use-case (npm scripts) so things are a bit clearer.

@shuyaqian
Copy link
Contributor

@idoprz I took the liberty of updating the title and description and use-case (npm scripts) so things are a bit clearer.

Is this question in the development plan for the next release? I've had the same problem with no search function when there are long lists in extension and the experience is really not good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree issues related to the tree (ex: tree widget) vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants