Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax issue with generated backend/frontend code #12670

Closed
walisc opened this issue Jun 30, 2023 · 2 comments · Fixed by #12590
Closed

Syntax issue with generated backend/frontend code #12670

walisc opened this issue Jun 30, 2023 · 2 comments · Fixed by #12590

Comments

@walisc
Copy link

walisc commented Jun 30, 2023

Is there any particular reason for the return statement here:

if (isSingleInstance && !app.requestSingleInstanceLock()) {
// There is another instance running, exit now. The other instance will request focus.
app.quit();
return;
}

Causes issues post-processing the generated file (e.g linting) as the return statement is being used outside a function body.


p.s in v1.37 / v1.38 this is here:

if (isSingleInstance && !app.requestSingleInstanceLock()) {
// There is another instance running, exit now. The other instance will request focus.
app.quit();
return;
}

@kittaakos
Copy link
Contributor

Same as #6675.

@walisc
Copy link
Author

walisc commented Jul 3, 2023

Same as #6675.

Do you know if there is any particular reason for it, or if it's a bug? Don't mind updating it if this is the case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants