Improve Helm Charts

[florianrusch-zf]

Is your feature request related to a problem? Please describe.
The helm charts can be improved to provide more flexibility and to follow more the best practice guidelines (https://helm.sh/docs/chart_best_practices/templates/).

Points to improve

• Use the _helpers.tpl and define functions for the following points. Helm improvement #281
  • Chart Name (registry.name)
  • Fully qualified app name (registry.fullname)
  • Chart name + version (registry.chart)
  • Labels (registry.labels)
  • SelectorLabels (registry.selectorLabels)
• Provide possibility to define the security contexts of the deployment & pod Make securityContext (pod and container) configurable #311
• Provide possibility to define custom env variables (directly and via configmaps and secrets) #312
• Provide possibility to customize liveness & readinessProbe
• In regards to Provide prometheus based metrics #127 it would be also beneficial to provide a ServiceMonitor resource
• Remove unneeded variables Helm improvement #281

Open points

• Can the registry been scaled horizontally? If yes, the helm chart should also provide an HorizontalPodAutoscaler resource.

[agg3fe]

Hi,
Thanks for reporting. We will analyse this issue. Will provide you the feedback on it.

[ds-lcapellino]

Is there any update on this issue?
We at TraceX can't properly sync our Argo environment because of the hard coded metadata.name attribute in:

• test-credentials.yaml
• test-script-configmap.yaml
• init-script-configmap.yaml

If we run two instances of registries in our ArgoCD they somehow always override each other while syncing. I guess it's because of the above-mentioned hard coded name attributes.

[tunacicek]

Hi together,
The following PR has been created and is under review.
#281

[thomas-henn]

eclipse-tractusx/sig-release#347

[tunacicek]

@ds-lcapellino The PR is merged and the changes are available with helm release version 0.4.0

[tunacicek]

@florianrusch-zf : for the security Context the following PR is created:
https://github.com/eclipse-tractusx/sldt-digital-twin-registry/pull/311/files

[tunacicek]

@florianrusch-zf : If it is ok for you, i would close this issue. For the other open points we have the following issues:
#312
#127