Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added the correct type for owned-credentials method #193

Conversation

leandro-cavalcante
Copy link
Contributor

@leandro-cavalcante leandro-cavalcante commented Jul 5, 2024

Description

Changed the object type CredentialDetailData to OwnedVerifiedCredentialData in the response of the Endpoint GET /api/issuer/owned-credentials.

Why

The current OpenAI documentation for the endpoint GET /api/issuer/owned-credentials displays an incorrect response body

Issue

N/A

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@jjeroch jjeroch requested review from Phil91 and ntruchsess July 5, 2024 18:34
@jjeroch
Copy link
Contributor

jjeroch commented Jul 5, 2024

Functional Requester: myself
@evegufy can you please switch the branch to /release/v1.1.0-rc.1

@jjeroch jjeroch added the priority PR needs to prioritized at review label Jul 5, 2024
@evegufy evegufy changed the base branch from main to release/v1.1.0-rc.1 July 5, 2024 18:37
@evegufy
Copy link
Contributor

evegufy commented Jul 5, 2024

Hi @leandro-cavalcante thanks for your contribution! could you please rebase to the release branch (dropping all the commits which aren't yours?

@jjeroch jjeroch mentioned this pull request Jul 5, 2024
7 tasks
@leandro-cavalcante leandro-cavalcante force-pushed the bug/Correction-of-Response-Body-in-Documentation-for-Endpoint branch from be6415a to dbf0713 Compare July 8, 2024 09:15
@leandro-cavalcante
Copy link
Contributor Author

Hi @leandro-cavalcante thanks for your contribution! could you please rebase to the release branch (dropping all the commits which aren't yours?

Thank you Evelyn, now the branch is rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants