Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set companyName for credentialApproval #218

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 25, 2024

Description

adjusting the approval mail to include the bpn as company identifier

Why

Since we don't have the company name available in the database of the ssi credential issuer we take the bpn, which is the only available information and set that as a identifier for the company in the approval mailing

Issue

Refs: #215

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested a review from evegufy July 25, 2024 11:45
Copy link

@Phil91 Phil91 requested a review from ntruchsess July 25, 2024 12:12
@Phil91 Phil91 merged commit 32bb69c into release/v1.1.0-rc.2 Jul 25, 2024
10 checks passed
@Phil91 Phil91 deleted the bugfix/215-approval-email branch July 25, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants