Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Missing BPN Names in IRS Job Response #1099

Closed
ds-mwesener opened this issue Jun 24, 2024 · 2 comments
Closed

Handle Missing BPN Names in IRS Job Response #1099

ds-mwesener opened this issue Jun 24, 2024 · 2 comments

Comments

@ds-mwesener
Copy link
Contributor

As a system integrator,
I want to ensure that the attributes sentToName and createdByName are populated correctly,
so that our notification system functions as intended even when the IRS does not deliver BPN names within their jobResponse.

Hints / Details

  • The IRS no longer delivers BPN names within their jobResponse, which results in sentToName and createdByName attributes being null.
  • We need to either ensure that the bpdmClient works correctly to retrieve the BPN names, or manage the BPN names ourselves.
  • Investigate and decide the best approach: fixing the bpdmClient or implementing an alternative method to handle BPN names.
  • Ensure backward compatibility with the current system.

Acceptance Criteria

  • The sentToName and createdByName attributes are correctly populated for notifications.
  • If the bpdmClient is used, it retrieves and integrates BPN names accurately.
  • If an alternative method is implemented, it effectively manages and integrates BPN names.
  • Proper error handling and logging are in place for scenarios where BPN names cannot be retrieved.
  • Comprehensive unit and integration tests are created to validate the solution.

Out of Scope

  • Changes to the IRS jobResponse structure.
  • Modifications to other unrelated components of the notification system.
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Jun 24, 2024
@ds-mwesener ds-mwesener moved this from inbox to backlog in Trace-X Jun 24, 2024
@mkanal
Copy link
Contributor

mkanal commented Jul 2, 2024

Duplicate of #902 - should be closed.

@mkanal mkanal moved this from backlog to done in Trace-X Jul 2, 2024
@mkanal
Copy link
Contributor

mkanal commented Jul 2, 2024

Duplicate of #902

@mkanal mkanal marked this as a duplicate of #902 Jul 2, 2024
@mkanal mkanal closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

2 participants