Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error and success result of QualityNotifications(Alert / Investigation) #510

Closed
2 tasks
ds-ashanmugavel opened this issue Dec 21, 2023 · 1 comment
Closed
2 tasks
Labels
concept issues describing to work on a concept DISCUSSION_NEEDED This ticket needs discussion within teammembers frontend Frontend related Issues

Comments

@ds-ashanmugavel
Copy link
Contributor

ds-ashanmugavel commented Dec 21, 2023

As a User
I want _ to see the status of my sent/received QualityNotificationMessages
so that I have a detailed overview of the success/error messages

Hints / Details

The QualityNotificationResponse class could be extended like the following:

As Is To Be
private Long id; private Long id;
private QualityNotificationStatusResponse status; private QualityNotificationStatusResponse status;
private String description; private String description;
private String createdBy; private String createdBy;
private String createdByName; private String createdByName;
private String createdDate; private String createdDate;
private List assetIds; private List assetIds;
private QualityNotificationSideResponse channel; private QualityNotificationSideResponse channel;
private QualityNotificationReasonResponse reason; private QualityNotificationReasonResponse reason;
private String sendTo; private String sendTo;
private String sendToName; private String sendToName;
private QualityNotificationSeverityResponse severity; private QualityNotificationSeverityResponse severity;
private String targetDate; private String targetDate;
private String errorMessage; private String errorMessage;
//new:
private List qualityNotificationMessages;

The QualityNotificationMessages are already persistent on the database level. So there's only an additional mapping to the response model necessary.

One thing to keep in mind is that the errorMessage field has to be moved to the new QualityNotificationMessageResponse class. The error message should be shown on the message level and not on the parent-notification level. The errorMessage field is currently always null. However, FE reads this attribute in the reponse of the BE

Acceptance Criteria

  • [FE] Concept of how to display error / success for notifications has been created
  • [FE] Follow up story for implementation has been created.## Out of Scope

Out of Scope

@github-project-automation github-project-automation bot moved this to inbox in Trace-X Dec 21, 2023
@jzbmw jzbmw added frontend Frontend related Issues concept issues describing to work on a concept DISCUSSION_NEEDED This ticket needs discussion within teammembers labels Jan 9, 2024
@jzbmw jzbmw changed the title ❓ [FE][Concept] Display error and success result of QualityNotifications(Alert / Investigation) Display error and success result of QualityNotifications(Alert / Investigation) Jan 9, 2024
@ds-mwesener
Copy link
Contributor

This has been adressed by #962

@ds-mwesener ds-mwesener closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept issues describing to work on a concept DISCUSSION_NEEDED This ticket needs discussion within teammembers frontend Frontend related Issues
Projects
Status: inbox
Development

No branches or pull requests

3 participants