Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport DataPlaneId null as non existing DataFlow in TransferProcess logic to version 0.7.5 #1535

Closed
bmg13 opened this issue Sep 5, 2024 · 4 comments · Fixed by #1534
Closed

Backport DataPlaneId null as non existing DataFlow in TransferProcess logic to version 0.7.5 #1535

bmg13 opened this issue Sep 5, 2024 · 4 comments · Fixed by #1534
Assignees
@bmg13
Labels
bug Something isn't working triage all new issues awaiting classification

Comments

@bmg13
Copy link
Contributor

bmg13 commented Sep 5, 2024

WHAT

Add a fix related with the null dataplaneId value in a TransferProcess, assuming it as terminated if no DataFlow is defined.

WHY

Avoiding throwing exceptions when a TP can be considered terminated. Similar to eclipse-edc/Connector#4420

FURTHER NOTES

This the same as eclipse-edc/Connector#4418 but transposed to the Tractus-X to be available to as a bugfix to v0.7.X
@bmg13 bmg13 added bug Something isn't working triage all new issues awaiting classification labels Sep 5, 2024
@bmg13
Copy link
Contributor Author

bmg13 commented Sep 9, 2024 •
edited
Loading

@paullatzelsperger can you assign this to me, please? PR is already up

@paullatzelsperger
Copy link
Contributor

@bmg13 pls also link this issue in the PR

@bmg13
Copy link
Contributor Author

bmg13 commented Sep 9, 2024

Already did, but was not linked here, not sure why.
PR: #1534

@paullatzelsperger paullatzelsperger linked a pull request Sep 9, 2024 that will close this issue
Fix: dataplaneId null for older TransferProcesses #1534
Merged
@bmg13 bmg13 mentioned this issue Sep 11, 2024
Merged
@ndr-brt
Copy link
Contributor

ndr-brt commented Sep 16, 2024

closed by #1534

@ndr-brt ndr-brt closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmg13 bmg13

Labels
bug Something isn't working triage all new issues awaiting classification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: dataplaneId null for older TransferProcesses bmg13/tractusx-edc
3 participants
@ndr-brt @bmg13 @paullatzelsperger