Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.7.5 Duplicate Transfer-Data-Plane-Signaling Dependencies in edc-controlplane-base Module? #1577

Open
wolf4ood opened this issue Sep 23, 2024 Discussed in #1576 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@wolf4ood
Copy link
Contributor

Discussed in #1576

Originally posted by efiege September 23, 2024
During our review of the dependency tree for the edc-controlplane-postgresql-azure-vault module, we observed that both the following dependencies are being included:

  • org.eclipse.edc:transfer-data-plane-signaling:0.7.2
  • project :edc-extensions:transfer-dataplane-signaling

It appears that the version included in this repository is a patched version of org.eclipse.edc:transfer-data-plane-signaling:0.7.2, addressing this issue: #1534.

However, having both dependencies included might result in the registration of two DataPlaneSignalingFlowController instances within the DataFlowManager, one with the fix and one without. This could potentially cause the EDC to load the unpatched version, depending on how it resolves these extensions.

The unpatched core EDC version is referenced here:

edc-dpf = ["edc.dpf-transfer-signaling", "edc.dpf-selector-core", "edc.spi-dataplane-selector"]

@wolf4ood wolf4ood added the bug Something isn't working label Sep 23, 2024
@wolf4ood
Copy link
Contributor Author

wolf4ood commented Sep 23, 2024

@bmg13 could you check this ?

Thanks

@bmg13
Copy link

bmg13 commented Sep 23, 2024

hey @wolf4ood good point, please assign it to me, will try to address it in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Open
Development

No branches or pull requests

2 participants