Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable/remove default plug-ins in Che Theia #13734

Closed
mmorhun opened this issue Apr 5, 2019 · 14 comments
Closed

Add ability to disable/remove default plug-ins in Che Theia #13734

mmorhun opened this issue Apr 5, 2019 · 14 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mmorhun
Copy link
Contributor

mmorhun commented Apr 5, 2019

Description

For now default plug-ins in Che Theia are build-in the Che Theia image. The goal of this issue is to allow disabling or removing some of them.
It might be helpful if some of default plug-ins are collided with functionality which is needed to be tested or developed. For example, development of one of the default plug-ins.

@makandre
Copy link

makandre commented Apr 11, 2019

This would be useful for people building on top of Che Theia and want to, for example, disable the welcome-plugin and provide their own (edit: or is there a way to brand/customize the default welcome page?)

@benoitf benoitf transferred this issue from eclipse-che/che-theia Jul 5, 2019
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. labels Jul 5, 2019
@sunix
Copy link
Contributor

sunix commented Jul 11, 2019

I don't think this is wanted for the end user.
But maybe when building the image, a more generic https://github.com/eclipse/che-theia/blob/master/che-theia-init-sources.yml kind of file that would also include binaries of plugins/ext to download and include in the final assembly package ?

@mmorhun
Copy link
Contributor Author

mmorhun commented Jul 22, 2019

I think it is still actual. For example, sometimes I want to disable ports plugin to avoid notification for known servers. But I cannot do it as for now.

@sunix
Copy link
Contributor

sunix commented Jul 23, 2019

@mmorhun could you create an issue describing the flow that is wrong from the end user perspective ? Describe what is wrong with the notifications, in which use case, etc ...
The problem with the current issue is that it may be only one solution for a problem. Maybe we could fix it in another way. Describing the problem would also help us to prioritize.
Thanks.

@mmorhun
Copy link
Contributor Author

mmorhun commented Jul 24, 2019

@sunix I am afraid we do not have other solution. If we have a plugin which does something a user doesn't want, the only way to fix it is just disable/remove the plugin.
As about specific use cases. I think it is up to specific user and I cannot describe all the use cases here.
Personally for me, ports plugin is annoying with its notifications and for most cases I would like to have it disabled. But it is only me. Another user may found it extremely useful. It is more matter of needs and taste. What we should do is to make users comfortable, give them a choice.

@sunix
Copy link
Contributor

sunix commented Jul 24, 2019

#13964 may be an example of improvement without having the user to remove plugins. We don't want the end user to disable a plug-in because it is 'annoying' but suggest him to create issues to improve the UX.

@mmorhun
Copy link
Contributor Author

mmorhun commented Jul 24, 2019

@sunix in the issue you mentioned we have problem of different kind: the link is not correct, which should be fixed. Here I talk about correct (from formal point of view) behaviour which not always desired by user.
So, to me it is better to have things configurable than trying to make them comfortable for everyone.

@vitaliy-guliy
Copy link
Contributor

@sunix I would like to have an ability to disable (don't remove) default plugins. Why you don't allow me to do that?

@sunix
Copy link
Contributor

sunix commented Jul 24, 2019

@vitaliy-guliy please create an issue explaining the value for the end user through a real case scenario. And let the triage team decide if this is to be done or not and when.

@vitaliy-guliy
Copy link
Contributor

Why do we need another issue? Is this one not good?

@sunix
Copy link
Contributor

sunix commented Jul 24, 2019

This one solution to a problem. but the problem could have multiple ways to be solve. Please create an issue...

@vitaliy-guliy
Copy link
Contributor

I don't understand why do we need several issues on one thing. Is not that enough?
Could you explain why you insist on not giving the user to have this feature.
Having a welcome plugin always turned on, how can I build it from sources and run hosted Theia to test?

@sunix
Copy link
Contributor

sunix commented Jul 24, 2019

I will give you only one because we are all busy for the release....
--> You have to test our product ... not a product without this or that. If it is wrong to display the welcome plugin all the time. please open an issue about that and explain how painful it is. and triage team will prioritize. Why not just display welcome page only the first time during a user session ?, there are different ways to solve your issues without having to disable things.

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2020
@che-bot che-bot closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants