This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Adapt WebView to Che in single-host mode (for 7.20.x) #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
azatsarynnyy
requested review from
benoitf and
RomanNikitenko
as code owners
RomanNikitenko
approved these changes
Nov 24, 2020
|
I've verified it with the following Devfile apiVersion: 1.0.0
metadata:
name: wksp-7.20
components:
- type: cheEditor
reference: 'https://gist.githubusercontent.com/azatsarynnyy/fe6f615443a3434b2430ca2513bd5e87/raw/97aa256fd5af417c25892cf87ed7c4d2df1d633a/meta.yaml'
|
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com
What does this PR do?
It contains only required changes from #932 in order to fix WebView loading in Che 7.20.x
It's needed for downstream release https://issues.redhat.com/browse/CRW-1393
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable