Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quarkus] tasks.json file is overridden by quarkus extension #15523

Closed
svor opened this issue Dec 18, 2019 · 3 comments
Closed

[Quarkus] tasks.json file is overridden by quarkus extension #15523

svor opened this issue Dec 18, 2019 · 3 comments
Assignees
Labels
area/languages Issues related to Language extensions or plugins integration. kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@svor
Copy link
Contributor

svor commented Dec 18, 2019

VS Code Quarkus extension contributes new task into tasks.json, it happens when user executes Quarkus: Debug current Quarkus project command. As a result .theia/.tasks.json is updated and loses all previous tasks.

@svor svor added kind/bug Outline of a bug - must adhere to the bug report template. team/languages area/languages Issues related to Language extensions or plugins integration. labels Dec 18, 2019
@svor
Copy link
Contributor Author

svor commented Dec 18, 2019

After quick investigation I see that the extension checks if .vscode/tasks.json exists and if it doesn't, it calls the API to update tasks configuration

workspace.getConfiguration('tasks', this.workspaceFolder.uri).update('tasks', []);

this code writes empty list of tasks into .theia/.tasks.json and removes all existed tasks in .theia/.tasks.json.

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 18, 2019
@tsmaeder
Copy link
Contributor

@svor that sounds like a bug in VS Code-Quarkus, though: I don't think the existence of the fiel tasks.json in official API. Shouldn't they go through API to check for preexisting tasks?

@tsmaeder tsmaeder mentioned this issue Dec 18, 2019
28 tasks
@svor
Copy link
Contributor Author

svor commented Dec 18, 2019

@tsmaeder I agree that changes should be provided into VS Code Quarkus extension, because it doesn't use API to check for preexisting tasks, they just check if /.vscode/launch.json file exists

fs.existsSync(workspaceFolder/.vscode/launch.json)

and it works for vscode but doesn't work for theia.

@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 18, 2019
@svor svor self-assigned this Dec 20, 2019
@svor svor closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

No branches or pull requests

4 participants