Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding git lfs support #20642

Closed
ffalkenberg opened this issue Oct 15, 2021 · 5 comments
Closed

Adding git lfs support #20642

ffalkenberg opened this issue Oct 15, 2021 · 5 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Milestone

Comments

@ffalkenberg
Copy link

ffalkenberg commented Oct 15, 2021

Summary

Hi,

using the devfile below I am setting up my WS.
The repo gets cloned but the git-lfs stored files only contain references (theia-editor only contains git, not git lfs)
How could I install git lfs into the theia-editor and would that fix it? (It seems to be a javascript image)
Or would I have to install it into a different image?

Thanks in advance.

Relevant information

apiVersion: 1.0.0
metadata:
  name: example
projects:
  - name: example
    source:
      location: 'git@github<>.net:example.git'
      type: github
components:
    reference: https://<example-plugin-registry>/7.31.0/v3/plugins/ms-python/python/latest/meta.yaml
    type: chePlugin
  - alias: theia-editor
    type: cheEditor
    reference: https://<example-plugin-registry>/7.31.0/v3/plugins/eclipse/che-theia/latest/meta.yaml

Release Notes Text

Che workspaces are now supporting Git Large File Storage extension https://git-lfs.github.com/

@ffalkenberg ffalkenberg added the kind/question Questions that haven't been identified as being feature requests or bugs. label Oct 15, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 15, 2021
@benoitf
Copy link
Contributor

benoitf commented Oct 15, 2021

Hello, here is a PR: eclipse-che/che-theia#1236

@benoitf benoitf added area/devworkspace-operator area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. kind/question Questions that haven't been identified as being feature requests or bugs. labels Oct 15, 2021
@ffalkenberg
Copy link
Author

wow, thanks alot!

@sleshchenko
Copy link
Member

since it got DWO area and the PR is merged devfile/devworkspace-operator#649 closing this issue

@benoitf benoitf reopened this Oct 21, 2021
@benoitf benoitf self-assigned this Oct 21, 2021
@benoitf benoitf changed the title Adding git lfs support for che-theia Adding git lfs support Oct 21, 2021
@benoitf
Copy link
Contributor

benoitf commented Oct 21, 2021

reopening as it's still not working on universal base image

@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Oct 26, 2021
@l0rd l0rd added this to the 7.38 milestone Oct 26, 2021
@benoitf benoitf closed this as completed Oct 28, 2021
@nickboldt nickboldt reopened this Nov 15, 2021
@nickboldt
Copy link
Contributor

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-2551

@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Projects
None yet
Development

No branches or pull requests

7 participants