Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard does not try to authenticate when factory/resolver returns 401 SCM Authentication required #20835

Closed
xbaran4 opened this issue Nov 26, 2021 · 0 comments · Fixed by eclipse-che/che-dashboard#411
Closed

Dashboard does not try to authenticate when factory/resolver returns 401 SCM Authentication required #20835

xbaran4 opened this issue Nov 26, 2021 · 0 comments · Fixed by eclipse-che/che-dashboard#411
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@xbaran4
Copy link
Contributor

xbaran4 commented Nov 26, 2021

Describe the bug

If che-server's factory/resolver returns 401 SCM Authentication required, dashboard does not try to authenticate. Authentication is mandatory in order to create workspace from private repository through factory.

Che version

other (please specify in additional context)

Steps to reproduce

Issue was found while working on github oauth. Steps to reproduce can be found in PR how to test: eclipse-che/che-server#178

Expected behavior

Dashboard should try to authenticate through oauth_authenticate_url that is in the 401 response.

Runtime

OpenShift

Screenshots

image

Installation method

chectl/next

Environment

other (please specify in additional context)

Eclipse Che Logs

No response

Additional context

Che version with before mentioned PR.
Environment: RHPDS
@xbaran4 xbaran4 added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/dashboard team/controller labels Nov 26, 2021
@akurinnoy akurinnoy mentioned this issue Nov 26, 2021
Merged
@xbaran4 xbaran4 mentioned this issue Nov 26, 2021
Merged
9 tasks
@xbaran4 xbaran4 changed the title Dashboard does not try to authenticate when when factory/resolver returns 401 SCM Authentication required Dashboard does not try to authenticate when factory/resolver returns 401 SCM Authentication required Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: factory resolver to respect the OAuth response eclipse-che/che-dashboard
1 participant
@xbaran4