Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customizing the PVC size for internal PostgreSQL instance #20837

Closed
gaocegege opened this issue Nov 29, 2021 · 5 comments
Closed

Support customizing the PVC size for internal PostgreSQL instance #20837

gaocegege opened this issue Nov 29, 2021 · 5 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.40

Comments

@gaocegege
Copy link

gaocegege commented Nov 29, 2021 •
edited by l0rd
Loading

Is your enhancement related to a problem? Please describe

No

Describe the solution you'd like

Now we hard-coded the PVC requests to 1Gi. It is better to support the custom size.

https://github.com/eclipse-che/che-operator/blob/b4930b5054c0bb951e8b3fcd5ab859a8eb671c7e/pkg/deploy/postgres/postgres.go#L78

I expect that the value should be configurable.

Describe alternatives you've considered

No response

Additional context

No response

Release Notes Text

CheCluster CR now has a database.pvcClaimSize field where administrators can specify a custom value for the database persistent volume. This is important because some public cloud providers' cloud disk does not support 1Gi, the minimum storage size is 10Gi.
@gaocegege gaocegege added the kind/enhancement A feature request - must adhere to the feature request template. label Nov 29, 2021
@gaocegege
Copy link
Author

eclipse-che/che-operator#1193

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 29, 2021
@tolusha
Copy link
Contributor

tolusha commented Nov 30, 2021

Hi.
That's not a big deal to make it configurable.
But could you describe a case when pvc 1Gi is not enough for PostgreSQL data?
Would it help you spec.storage.pvcClaimSize to configure pvc size for workspace data.

@gaocegege
Copy link
Author

But could you describe a case when pvc 1Gi is not enough for PostgreSQL data?

Some public cloud providers' cloud disk does not support 1Gi. The minimum storage size is 10Gi. Thus the PVC cannot be provisioned successfully.

@tolusha
Copy link
Contributor

tolusha commented Nov 30, 2021

I see. Thank you!

@tolusha tolusha added sprint/next severity/P2 Has a minor but important impact to the usage or development of the system. team/deploy labels Nov 30, 2021
@tolusha tolusha mentioned this issue Nov 30, 2021
Closed
28 tasks
@svor svor removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 30, 2021
@tolusha tolusha mentioned this issue Nov 30, 2021
Merged
11 tasks
@tolusha tolusha modified the milestones: 7.40, 7.41 Dec 1, 2021
@tolusha tolusha closed this as completed Dec 1, 2021
@l0rd l0rd changed the title feature request: Support custom Postgres PVC size Support customizing the PVC size of the internal PostgreSQL Dec 7, 2021
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Dec 7, 2021
@nickboldt
Copy link
Contributor

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-2548

@l0rd l0rd changed the title Support customizing the PVC size of the internal PostgreSQL Support customizing the PVC size for internal PostgreSQL instance Dec 10, 2021
@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.40
Development

No branches or pull requests
7 participants
@nickboldt @l0rd @svor @tolusha @gaocegege @che-bot @max-cx