Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure subdomain isolation for GitHub Enterprise Server in CheCluster CR #21724

Closed
l0rd opened this issue Sep 23, 2022 · 5 comments
Closed
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/che-server kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Sep 23, 2022

Is your enhancement related to a problem? Please describe

GitHub Enterprise Server customers have the option to enable/disable subdomain isolation. URLs to GitHub resources depend on this configuration:

Path without subdomain isolation Path with subdomain isolation
`http(s)://HOSTNAME/raw/` `http(s)://raw.HOSTNAME/`

Describe the solution you'd like

A Dev Spaces admin should be able to specify if subdomain-isolated is enabled or not in CheCluster CR:

spec:
  gitServices:
    github:
      - endpoint: 'https://github.com'
        secretName: github-oauth-config
        disableSubdomainIsolation: true 

And Che server should use paths with or without subdomain isolation, when resolving GitHub files, based on that configuration.

Note: GitHub suggest to enable subdomain-isolation so when not specified we assume that disableSubdomainIsolation: false (that's also the github.com config anyway)

Release Notes Text

In GitHub Enterprise Server subdomains can be isolated (as it's the case for github.com) and it's now supported by Eclipse Che.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 23, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 23, 2022
@l0rd l0rd added area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/che-server severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 23, 2022
@tolusha
Copy link
Contributor

tolusha commented Sep 25, 2022

Maybe subdomainIsolationIsDisabled -> disableSubdomainIsolation ?

@vinokurig
Copy link
Contributor

Maybe subdomainIsolationIsDisabled -> disableSubdomainIsolation ?

+1

@l0rd
Copy link
Contributor Author

l0rd commented Sep 26, 2022

@tolusha you are right, much better. I have updated the description.

@vinokurig vinokurig self-assigned this Sep 26, 2022
@l0rd l0rd added this to the 7.55 milestone Sep 29, 2022
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Sep 29, 2022
@tolusha tolusha closed this as completed Sep 29, 2022
@max-cx
Copy link

max-cx commented Dec 16, 2022

Sync'd with Red Hat JIRA https://issues.redhat.com/browse/CRW-3639

@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
@devstudio-release
Copy link

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/che-server kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants