Allow to configure subdomain isolation for GitHub Enterprise Server in CheCluster CR #21724
Labels
area/che-operator
Issues and PRs related to Eclipse Che Kubernetes Operator
area/che-server
kind/enhancement
A feature request - must adhere to the feature request template.
new¬eworthy
For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
severity/P1
Has a major impact to usage or development of the system.
Milestone
Is your enhancement related to a problem? Please describe
GitHub Enterprise Server customers have the option to enable/disable subdomain isolation. URLs to GitHub resources depend on this configuration:
Describe the solution you'd like
A Dev Spaces admin should be able to specify if subdomain-isolated is enabled or not in CheCluster CR:
And Che server should use paths with or without subdomain isolation, when resolving GitHub files, based on that configuration.
Note: GitHub suggest to enable subdomain-isolation so when not specified we assume that
disableSubdomainIsolation: false
(that's also the github.com config anyway)Release Notes Text
In GitHub Enterprise Server subdomains can be isolated (as it's the case for
github.com
) and it's now supported by Eclipse Che.The text was updated successfully, but these errors were encountered: