-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DevWorkspace Operator contributions attributes to inject editors into Devfile containers #21738
Use DevWorkspace Operator contributions attributes to inject editors into Devfile containers #21738
Comments
@olexii4 I think you can reuse che-devworkspace-generator npm library to prepare DevWorkspaces with container contributions attributes as it was done in the che-devfile registry |
Probably it's not finished yet |
did all the changes to che-plugin-reg upstream get ported downstream fork too? Not seeing matching changes in https://github.com/redhat-developer/devspaces/commits/devspaces-3-rhel-8/dependencies/che-plugin-registry ... please throw PRs at that repo and if no one is responding, ping in Slack for more 👀 |
Is your enhancement related to a problem? Please describe
Currently, the dashboard uses a library to inject editors into devfiles, which results in modifying the original devfile in the process of converting it into a DevWorkspace. DevWorkspace Operator PR devfile/devworkspace-operator#844 adds attributes on components that hopefully remove the need for this process:
controller.devfile.io/container-contribution: true
defines a container component as a "container contribution"controller.devfile.io/merge-contribution: true
defines a container as a target for merging a "container contribution"When present, these attributes define a component as a "contribution" that gets merged into the target, replicating the process performed by the dashboard in a (hopefully) simpler way. See details on original PR for how this works.
Describe the solution you'd like
controller.devfile.io/merge-contribution: true
attribute to the Devfile component we currently inject editors into (e.g.tools
)Describe alternatives you've considered
It may be possible to do the steps above separately, i.e. begin adding the attribute but continuing to use the merge functionality as well. This would need to be tested but would reduce the coordination necessary between registries/dashboard/DWO to make everything work as intended without breaking an edge case.
Additional context
Relevant DWO PRs:
.spec.contributions
field in DevWorkspace devfile/devworkspace-operator#939This issue is part of #21736
The text was updated successfully, but these errors were encountered: