Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupled monitoring configuration and deployment #13152

Merged
merged 7 commits into from
Jun 7, 2019

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Decoupled monitoring configuration and deployment.
Separated.

  • Deployment grafana, Prometheus
  • Grafana dashboard
  • Grafana config
  • Prometheus

In this way, the downstream project can reuse some parts of the monitoring configuration.

What issues does this PR fix or reference?

redhat-developer/rh-che#1336

Release Notes

n/a

Docs PR

n/a

@ibuziuk
Copy link
Member

ibuziuk commented Apr 15, 2019

@skabashnyuk looks good, but from osio deployment perspective having single template and multiple cms would be problematic to apply via standard CI/CD procedure. Will it be possible to have only che-monitoring.yaml and che-monitoring.config.yaml for the time being?

@ibuziuk ibuziuk self-requested a review April 15, 2019 16:29
@ibuziuk
Copy link
Member

ibuziuk commented Apr 15, 2019

@skabashnyuk actually, after thinking a little bit - let's not do any refactoring for the time being and use just one single template like it is used in plugin registry https://github.com/eclipse/che-plugin-registry/blob/master/openshift/che-plugin-registry.yml

PR sent - redhat-developer/che-monitoring#1

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk skabashnyuk marked this pull request as ready for review June 5, 2019 14:11
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 6, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13152
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk skabashnyuk merged commit ea4b2ee into master Jun 7, 2019
@skabashnyuk skabashnyuk deleted the monitoringconfigsplit branch June 7, 2019 06:23
@che-bot che-bot added this to the 7.0.0 milestone Jun 27, 2019
@che-bot che-bot added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants