Merge api-devfile and api-workspace together #13417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the infrastructure-dependent code behind injectable interfaces. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
I created an associated PR for the library updates in |
|
ci-build |
|
Ah, this won't pass the build check until eclipse-che/che-parent#117 is merged. |
mshaposhnik
reviewed
May 27, 2019
mshaposhnik
reviewed
May 27, 2019
...api/workspace/devfile/server/convert/component/plugin/PluginComponentToWorkspaceApplier.java
Outdated
Show resolved
Hide resolved
mshaposhnik
requested review from
amisevsk,
skabashnyuk,
sleshchenko and
tolusha
as code owners
amisevsk
reviewed
May 27, 2019
...rg/eclipse/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentValidator.java
Outdated
Show resolved
Hide resolved
...clipse/che/workspace/infrastructure/kubernetes/devfile/KubernetesEnvironmentProvisioner.java
Show resolved
Hide resolved
...clipse/che/workspace/infrastructure/kubernetes/devfile/KubernetesEnvironmentProvisioner.java
Outdated
Show resolved
Hide resolved
...e/workspace/infrastructure/kubernetes/devfile/KubernetesComponentIntegrityValidatorTest.java
Outdated
Show resolved
Hide resolved
...e/workspace/infrastructure/kubernetes/devfile/KubernetesComponentIntegrityValidatorTest.java
Show resolved
Hide resolved
...e/workspace/infrastructure/kubernetes/devfile/KubernetesComponentToWorkspaceApplierTest.java
Outdated
Show resolved
Hide resolved
...core-api-workspace/src/main/java/org/eclipse/che/api/workspace/devfile/server/Constants.java
Outdated
Show resolved
Hide resolved
...-api-workspace/src/main/java/org/eclipse/che/api/workspace/devfile/server/DevfileModule.java
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
May 28, 2019
...pi-workspace/src/main/java/org/eclipse/che/api/workspace/devfile/server/DevfileBindings.java
Outdated
Show resolved
Hide resolved
...api-workspace/src/main/java/org/eclipse/che/api/workspace/devfile/server/DevfileManager.java
Outdated
Show resolved
Hide resolved
...core-api-workspace/src/main/java/org/eclipse/che/api/workspace/devfile/server/Constants.java
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
May 28, 2019
...-api-workspace/src/main/java/org/eclipse/che/api/workspace/devfile/server/DevfileModule.java
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
May 28, 2019
...-api-workspace/src/main/java/org/eclipse/che/api/workspace/devfile/server/DevfileModule.java
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
May 28, 2019
...pi-workspace/src/main/java/org/eclipse/che/api/workspace/devfile/server/DevfileBindings.java
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
May 28, 2019
...a/org/eclipse/che/workspace/infrastructure/kubernetes/devfile/KubernetesDevfileBindings.java
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
May 28, 2019
.../che/workspace/infrastructure/kubernetes/devfile/DockerimageComponentToWorkspaceApplier.java
Show resolved
Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentValidator.java
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
May 28, 2019
…e-from-devfile-2 Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
are handled in the k8s infrastructure. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
sleshchenko
reviewed
May 29, 2019
...-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/devfile/DevfileModule.java
Outdated
Show resolved
Hide resolved
…eeded now that everything needed is colocated in the workspace module. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
sleshchenko
approved these changes
May 29, 2019
...rg/eclipse/che/workspace/infrastructure/kubernetes/devfile/KubernetesComponentValidator.java
Show resolved
Hide resolved
mshaposhnik
approved these changes
May 29, 2019
…e-from-devfile-2 Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
skabashnyuk
approved these changes
May 30, 2019
provided by the glassfish implementation Exclude icu4j originating from the server-side codebase because gwt comes with a different version. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
ci-build |
2 similar comments
|
ci-build |
|
ci-build |
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
This was referenced Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
... and put the infrastructure-dependent code behind injectable interfaces.
I had to update ASM (to the last version 7.1)
and explicitly set dependency onwhich will probably require to go through the CQ process.javax.json:json-apiboth ofWhat issues does this PR fix or reference?
#13315