[deploy/helm] backport changes from chectl for templates #13425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of them are because helm v2.14 is now performing 'validation' phase on templates Change-Id: I2e46d120237218be64061d4a6800124eedc9a919 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
I think it makes sense to make clear that some changes are done because of |
|
@akervern is it ok for you to have your changes merged as part of this PR ? |
l0rd
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
backport changes from chectl for templates
Many of them are because helm v2.14 is now performing 'validation' phase on templates
What issues does this PR fix or reference?
che-incubator/chectl#110
Change-Id: I2e46d120237218be64061d4a6800124eedc9a919
Signed-off-by: Florent Benoit fbenoit@redhat.com