Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-null constraints from some devfile fields; #13516

Merged
merged 3 commits into from
Jun 12, 2019

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Jun 11, 2019

This PR removes non-null constraints from some devfile fields, where it is not necessary:

  • Component of the command action;
  • Parent and container names of the entrypoint;

What issues does this PR fix or reference?

#13422

Release Notes

N/A

Docs PR

N/A

@sleshchenko
Copy link
Member

Does it solve #13422 ?

@mshaposhnik
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 11, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13516
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mshaposhnik mshaposhnik merged commit de24123 into master Jun 12, 2019
@mshaposhnik mshaposhnik deleted the SQL_refactoring branch June 12, 2019 06:40
@che-bot che-bot added this to the 7.0.0 milestone Jun 27, 2019
@che-bot che-bot added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants