Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creation of k8s secrets during deploying of broker #13546

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

sleshchenko
Copy link
Member

What does this PR do?

Adds creation of k8s secrets during deploying of broker.

This PR fixes the only one of the issues during Che 7 start with self-signed certificate and with these changes the following error appears
Screenshot_20190614_160204
Changes for plugin broker will be created in another PR.

What issues does this PR fix or reference?

Fixes #13433

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko sleshchenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 14, 2019
@sleshchenko sleshchenko requested a review from metlos June 14, 2019 13:04
@sleshchenko sleshchenko self-assigned this Jun 14, 2019
@sleshchenko
Copy link
Member Author

ci-test

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@che-bot
Copy link
Contributor

che-bot commented Jun 14, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13546
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1863//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@sleshchenko sleshchenko merged commit 9f652e5 into eclipse-che:master Jun 18, 2019
@che-bot che-bot added this to the 7.0.0 milestone Jun 27, 2019
@sleshchenko sleshchenko deleted the tlsSecret4Broker branch April 16, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume created but the secret with the self-signed cert is not
5 participants