Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change plugin registry to v3 #13548

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Change plugin registry to v3 #13548

merged 1 commit into from
Jun 17, 2019

Conversation

nickboldt
Copy link
Contributor

Change-Id:...

Change plugin registry to v3

Change-Id: I68d71bdc7ee6df1e175d39b198efcfeff29ca4f1
Signed-off-by: nickboldt nboldt@redhat.com

@nickboldt
Change plugin registry to v3
7fb788a 
Change-Id: I68d71bdc7ee6df1e175d39b198efcfeff29ca4f1
Signed-off-by: nickboldt <nboldt@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jun 14, 2019

Can one of the admins verify this patch?

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented Jun 14, 2019

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Jun 14, 2019

Can one of the admins verify this patch?

@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@nickboldt
Copy link
Contributor Author

Related to minishift/minishift#3273 and #13136 and https://github.com/eclipse/che/pull/11354/files#diff-700dab0819ba6724ee90d7050f15e35e

@benoitf
Copy link
Contributor

benoitf commented Jun 14, 2019

ci-build

benoitf
benoitf reviewed Jun 14, 2019
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci-test

@nickboldt nickboldt merged commit 68c7632 into eclipse-che:master Jun 17, 2019
@nickboldt
Copy link
Contributor Author

I'll never understand why your process isn't "approve AND merge at the same time", rather than having the original submitter merge the change... but anyway, thanks! Merged.

@nickboldt nickboldt deleted the che-plugin-registry_v3 branch June 17, 2019 14:15
@che-bot che-bot added this to the 7.0.0 milestone Jun 27, 2019
@che-bot che-bot added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf left review comments

@metlos metlos metlos approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nickboldt @che-bot @musienko-maxim @benoitf @metlos @skabashnyuk