Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Che Plugin Broker use self-signed certificate #13565

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Make Che Plugin Broker use self-signed certificate #13565

merged 1 commit into from
Jun 19, 2019

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Jun 18, 2019 •
edited
Loading

What does this PR do?

Makes Che Plugin Broker use a self-signed certificate to archive it was needed:

This is tested on local OCP deployed with ocp.sh:

./ocp.sh --run-ocp --deploy-che --multiuser --secure --no-pull --setup-ocp-oauth

https://youtu.be/8z8WXA82G28

What issues does this PR fix or reference?

#12634

Release Notes

N/A

Docs PR

N/A

@sleshchenko sleshchenko self-assigned this Jun 18, 2019
@sleshchenko
Make Che Plugin Broker use self-signed certificate
1ab7a0e 
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko sleshchenko marked this pull request as ready for review June 19, 2019 08:48
@sleshchenko sleshchenko mentioned this pull request Jun 19, 2019
Closed
@sleshchenko
Copy link
Member Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13565
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

amisevsk
amisevsk approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment.

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
@@ -560,8 +560,8 @@ che.singleport.wildcard_domain.ipless=false

# Docker image of Che plugin broker app that resolves workspace tooling configuration and copies
# plugins dependencies to a workspace
che.workspace.plugin_broker.init.image=eclipse/che-init-plugin-broker:v0.18
che.workspace.plugin_broker.unified.image=eclipse/che-unified-plugin-broker:v0.18
che.workspace.plugin_broker.init.image=eclipse/che-init-plugin-broker:v0.19.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we want to to use v0.19.0? If we use v0.19 we would pick up bugfix releases without further modification.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my fault that I specified v0.19.0 as dockerimage and latest dockerimage tag during releasing of che-plugin-broker and v0.19 is not available =(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries 👍

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1871//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@sleshchenko sleshchenko merged commit 16b157a into eclipse-che:master Jun 19, 2019
@sleshchenko sleshchenko deleted the pluginBrokerCerts branch June 19, 2019 13:27
@che-bot che-bot added this to the 7.0.0 milestone Jun 27, 2019
@che-bot che-bot added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

@metlos metlos Awaiting requested review from metlos

Assignees

@sleshchenko sleshchenko

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sleshchenko @che-bot @SkorikSergey @skabashnyuk @amisevsk