-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow registry passwords longer than 128 chars #13569
Conversation
Signed-off-by: John Collier <John.J.Collier@ibm.com>
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this PR? |
ci-build |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Is this PR good to be merged now? |
@l0rd Can we merge this PR now? Or it's better to merge after released 7.0.0? |
Considered the size of this PR and that it has been created before the code freeze I would be +1 to merge it now. @rhopp any concern? |
+1 to merge. |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
What does this PR do?
This PR allows users to specify passwords for docker registry credentials that are longer than 128 characters. Myself and some other team members have access to docker registries that use 128 characters and longer tokens for authentication, and Che was not allowing us to specify the credentials for the registry.
I've verified this change with both short and long tokens, including an 856 service account token used for pushing to an internal OpenShift registry
What issues does this PR fix or reference?
#5678
Release Notes
Allow registry passwords longer than 128 chars