-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy legacy variable only for che6 workspaces #13612
Conversation
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
LGTM |
...c/main/java/org/eclipse/che/api/workspace/server/spi/provision/env/LegacyEnvVarProvider.java
Show resolved
Hide resolved
...g/eclipse/che/api/workspace/server/spi/provision/env/LegacyEnvVarEnvironmentProvisioner.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other is LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. Please take a look inline comments
...g/eclipse/che/api/workspace/server/spi/provision/env/LegacyEnvVarEnvironmentProvisioner.java
Outdated
Show resolved
Hide resolved
...g/eclipse/che/api/workspace/server/spi/provision/env/LegacyEnvVarEnvironmentProvisioner.java
Outdated
Show resolved
Hide resolved
...g/eclipse/che/api/workspace/server/spi/provision/env/LegacyEnvVarEnvironmentProvisioner.java
Outdated
Show resolved
Hide resolved
...g/eclipse/che/api/workspace/server/spi/provision/env/LegacyEnvVarEnvironmentProvisioner.java
Show resolved
Hide resolved
ci-build |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1882/) doesn't show any regression against this Pull Request. |
What does this PR do?
Deploy legacy variable only for che6 workspaces
What issues does this PR fix or reference?
Release Notes
Docs PR