Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy legacy variable only for che6 workspaces #13612

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Deploy legacy variable only for che6 workspaces

What issues does this PR fix or reference?

Release Notes

Docs PR

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk skabashnyuk changed the title Deploy legacy variable only for che6 workspaces [WIP]Deploy legacy variable only for che6 workspaces Jun 21, 2019
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
@metlos metlos marked this pull request as ready for review June 25, 2019 15:50
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
@metlos metlos changed the title [WIP]Deploy legacy variable only for che6 workspaces Deploy legacy variable only for che6 workspaces Jun 25, 2019
@metlos
Copy link
Contributor

metlos commented Jun 25, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 25, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13612
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor Author

LGTM

Copy link
Contributor

@mshaposhnik mshaposhnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other is LGTM

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Please take a look inline comments

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 27, 2019
@mshaposhnik
Copy link
Contributor

ci-build

@mshaposhnik
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13612
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1882/) doesn't show any regression against this Pull Request.

@mshaposhnik mshaposhnik merged commit c2ee931 into master Jul 1, 2019
@mshaposhnik mshaposhnik deleted the legacyvar branch July 1, 2019 08:12
@che-bot che-bot added this to the 7.0.0 milestone Jul 1, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants