Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace termination time metrics #13635

Merged
merged 3 commits into from
Jul 2, 2019
Merged

Workspace termination time metrics #13635

merged 3 commits into from
Jul 2, 2019

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Jun 27, 2019

What does this PR do?

Adds new metrics measuring time of workspace termination.

workspace_stoptime

What issues does this PR fix or reference?

#13500

Release Notes

n/a

Docs PR

eclipse-che/che-docs#747

@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@sleshchenko
Copy link
Member

ci-build

Copy link
Contributor

@skabashnyuk skabashnyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a screenshot of how panels look like?

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jun 27, 2019
@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2019

Can one of the admins verify this patch?

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2019

Can one of the admins verify this patch?

@skabashnyuk
Copy link
Contributor

On the dashboard, we are using two new metrics. I wonder are we adding 3 new metrics (max, avg, count) or 3 + distribution(for heat map). Since we are not adding heat map as we do that for workspace start, can you make sure we are not adding unused metric?

@sparkoo
Copy link
Member Author

sparkoo commented Jul 1, 2019

On the dashboard, we are using two new metrics. I wonder are we adding 3 new metrics (max, avg, count) or 3 + distribution(for heat map). Since we are not adding heat map as we do that for workspace start, can you make sure we are not adding unused metric?

updated

/ $ curl http://localhost:8087 | grep ^che_workspace_stop_time
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 29105  100 29105    0     0  2186k      0 --:--:-- --:--:-- --:--:-- 2186k
che_workspace_stop_time_seconds_count{area="workspace",result="success",} 3.0
che_workspace_stop_time_seconds_sum{area="workspace",result="success",} 2.669
che_workspace_stop_time_seconds_max{area="workspace",result="success",} 0.464

Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
@metlos
Copy link
Contributor

metlos commented Jul 1, 2019

ci-build

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo
Copy link
Member Author

sparkoo commented Jul 1, 2019

ci-build

@skabashnyuk
Copy link
Contributor

ci-test

@metlos
Copy link
Contributor

metlos commented Jul 2, 2019

ci-build

@sparkoo
Copy link
Member Author

sparkoo commented Jul 2, 2019

updated image and added docs PR (eclipse-che/che-docs#747)

@che-bot
Copy link
Contributor

che-bot commented Jul 2, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13635
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor

CC @ibuziuk

@skabashnyuk skabashnyuk merged commit cd891d7 into eclipse-che:master Jul 2, 2019
@sparkoo sparkoo deleted the 13500-metrics-time-ws-termination branch July 8, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants