Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify url to get index.json #13645

Merged
merged 1 commit into from
Jul 15, 2019
Merged

modify url to get index.json #13645

merged 1 commit into from
Jul 15, 2019

Conversation

tobespc
Copy link
Contributor

@tobespc tobespc commented Jun 27, 2019

What does this PR do?

This PR resolves the issue #13634 . By actually specifying the index file rather than just having it served up by a service, it means the registry can be as simple as a git repo that contains that file or as advanced as being a hosted service. It gives more flexibiilty to users wanting to customise the location of the plugin templates

What issues does this PR fix or reference?

#13634

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2019

Can one of the admins verify this patch?

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2019

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2019

Can one of the admins verify this patch?

@tobespc tobespc changed the title modify url to get index,json modify url to get index.json Jun 27, 2019
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Jun 27, 2019
@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@makandre
Copy link

makandre commented Jul 3, 2019

Hi, any status update on this? I'm waiting for this to address #13634. Thank you.

Signed-off-by: Toby Corbin <corbint@uk.ibm.com>
@rhopp
Copy link
Contributor

rhopp commented Jul 10, 2019

Hi @makandre, we are now in semi-codefrozen state to harden the product before che 7.0 release happen - meaning any non-critical features & bugfixes shouldn't go to master branch.
If you think this feature is "must have" for Che 7, raise this on che-dev mailing list (https://accounts.eclipse.org/mailing-list/che-dev).

So far, I've triagged the #13634 issue (selected right team to raise awareness and set severity & milestone).

@nickboldt
Copy link
Contributor

Seems like a reasonable solution to make Che 7 a "harder" product. As it's a one-liner change, I'd be +1 for this being in 7.0.0, but if people feel differently, then we could push it to 7.1.0, 3 weeks later.

@l0rd
Copy link
Contributor

l0rd commented Jul 10, 2019

That's a dashboard change @ashumilova @evidolob can you please review?

@benoitf
Copy link
Contributor

benoitf commented Jul 11, 2019

ci-build

@benoitf
Copy link
Contributor

benoitf commented Jul 11, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 11, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13645
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1897//Selenium_20tests_20report/) doesn't show any regression against this Pull request.

@benoitf
Copy link
Contributor

benoitf commented Jul 12, 2019

@nickboldt @l0rd you commented for approval for 7.0.0 but didn't approved :-) could you ? thx

@l0rd
Copy link
Contributor

l0rd commented Jul 12, 2019

@benoitf that's because the associated issue is still flagged as 7.x

@benoitf
Copy link
Contributor

benoitf commented Jul 12, 2019

@l0rd ok so maybe we could move it to 7.0.0

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nickboldt
Copy link
Contributor

Seems like people agree this is something we can easily fix for 7.0.0.GA so I've set that label.

But as the happy path is failing and downstream dashboard changes may be required, I won't merge this yet. Back to you, @ashumilova and @benoitf

@nickboldt nickboldt added this to the 7.0.0 milestone Jul 12, 2019
@benoitf benoitf merged commit 7ca6954 into eclipse-che:master Jul 15, 2019
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants