-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify url to get index.json #13645
modify url to get index.json #13645
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this PR? |
Hi, any status update on this? I'm waiting for this to address #13634. Thank you. |
Signed-off-by: Toby Corbin <corbint@uk.ibm.com>
Hi @makandre, we are now in semi-codefrozen state to harden the product before che 7.0 release happen - meaning any non-critical features & bugfixes shouldn't go to master branch. So far, I've triagged the #13634 issue (selected right team to raise awareness and set severity & milestone). |
Seems like a reasonable solution to make Che 7 a "harder" product. As it's a one-liner change, I'd be +1 for this being in 7.0.0, but if people feel differently, then we could push it to 7.1.0, 3 weeks later. |
That's a dashboard change @ashumilova @evidolob can you please review? |
ci-build |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1897//Selenium_20tests_20report/) doesn't show any regression against this Pull request. |
@nickboldt @l0rd you commented for approval for 7.0.0 but didn't approved :-) could you ? thx |
@benoitf that's because the associated issue is still flagged as |
@l0rd ok so maybe we could move it to 7.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Seems like people agree this is something we can easily fix for 7.0.0.GA so I've set that label. But as the happy path is failing and downstream dashboard changes may be required, I won't merge this yet. Back to you, @ashumilova and @benoitf |
What does this PR do?
This PR resolves the issue #13634 . By actually specifying the index file rather than just having it served up by a service, it means the registry can be as simple as a git repo that contains that file or as advanced as being a hosted service. It gives more flexibiilty to users wanting to customise the location of the plugin templates
What issues does this PR fix or reference?
#13634
Release Notes
Docs PR