Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Change export logic #13697

Merged
merged 1 commit into from
Jul 4, 2019
Merged

[E2E] Change export logic #13697

merged 1 commit into from
Jul 4, 2019

Conversation

Katka92
Copy link
Contributor

@Katka92 Katka92 commented Jul 4, 2019

What does this PR do?

Name inversify.config export to make it initialised at a time of usage. This change is needed to make inversify usable as a dependency.

@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@benoitf
Copy link
Contributor

benoitf commented Jul 4, 2019

it seems it didn't notified the global owners of repository like @vparfonov @l0rd @rhopp @nickboldt

@rhopp
Copy link
Contributor

rhopp commented Jul 4, 2019

According to @Katka92, this one is needed for being able to run Happy Path on hosted che.
+1 to include this in Endgame.
@Ohrimenko1988 Your call about the technical side of things ;-)

@dmytro-ndp dmytro-ndp merged commit 283a21c into eclipse-che:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants