Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of error status of a workspace #13804

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Fix handling of error status of a workspace #13804

merged 3 commits into from
Sep 5, 2019

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR fixes bug when workspace-loader is not able to handle an error status which is set immediately after workspace has been started.

What issues does this PR fix or reference?

fix #13209
fix #13681

@akurinnoy
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 9, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13804
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@l0rd
Copy link
Contributor

l0rd commented Jul 9, 2019

@akurinnoy that doesn't look related to any issue included in the endgame issue. I think you are aware that unfortunately we cannot merge any issue that is not related to GA right now. Setting label do-not-merge.

@akurinnoy akurinnoy mentioned this pull request Jul 16, 2019
Closed
23 tasks
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 6, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Aug 6, 2019
@l0rd
Copy link
Contributor

l0rd commented Aug 22, 2019

@akurinnoy I am removing label do-not-merge/hold. Can you rebase please?

@akurinnoy
Copy link
Contributor Author

@l0rd sure, thanks!

@che-bot
Copy link
Contributor

che-bot commented Aug 23, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:13804

@che-bot
Copy link
Contributor

che-bot commented Aug 23, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@SkorikSergey
Copy link
Contributor

ci-build

@akurinnoy
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@olexii4
Copy link
Contributor

olexii4 commented Sep 2, 2019

LGTM

@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@akurinnoy
fixed handling of error status of a workspace after it has been started.
24cfad1 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
workaround for devserver proxy to replace header 'origin' with target…
cdfaa18 
… host

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
use string interpolation instead of concatenation
98c6d18 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:13804

@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@akurinnoy akurinnoy merged commit 208c4fb into eclipse-che:master Sep 5, 2019
skabashnyuk pushed a commit to skabashnyuk/che that referenced this pull request Mar 11, 2020
@akurinnoy
Fix handling of error status of a workspace (eclipse-che#13804)
2245ec8 
* fixed handling of error status of a workspace after it has been started.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* workaround for devserver proxy to replace header 'origin' with target host

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* use string interpolation instead of concatenation

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexii4 olexii4 olexii4 approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@mmorhun mmorhun mmorhun approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
7 participants
@akurinnoy @che-bot @l0rd @SkorikSergey @olexii4 @AndrienkoAleksandr @mmorhun