Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Diagnostics widget on UD #13815

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Remove Diagnostics widget on UD #13815

merged 1 commit into from
Jul 12, 2019

Conversation

akurinnoy
Copy link
Contributor

Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com

What does this PR do?

This PR removes Diagnostics directive and link to Diagnostics page in Dashboard footer.

What issues does this PR fix or reference?

fix #13525

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy akurinnoy added kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. target/che7GA labels Jul 11, 2019
@akurinnoy akurinnoy self-assigned this Jul 11, 2019
@akurinnoy
Copy link
Contributor Author

ci-test

@rhopp
Copy link
Contributor

rhopp commented Jul 11, 2019

@SkorikSergey @artaleks9 @dmytro-ndp Was this covered by selenium tests? If so, we need to delete/disable them too...

@dmytro-ndp
Copy link
Contributor

@rhopp : we don't have dedicated e2e tests to check Diagnostics tool.

@che-bot
Copy link
Contributor

che-bot commented Jul 11, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13815
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

SkorikSergey commented Jul 12, 2019

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1896//Selenium_20tests_20report/) doesn't show any regression against this Pull request.
HappyPath test failing doesn't related to this PR changes.

@akurinnoy akurinnoy merged commit 22c2385 into master Jul 12, 2019
@akurinnoy akurinnoy deleted the remove-diagnostics branch July 12, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove UD "Diagnostics" because it's not working
8 participants