Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt project selector widget to manage projects from devfile #13825

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Adapt project selector widget to manage projects from devfile #13825

merged 1 commit into from
Jul 15, 2019

Conversation

ashumilova
Copy link
Contributor

Signed-off-by: Anna Shumilova ashumilo@redhat.com

What does this PR do?

Changes for projects selector widget:

  • Removes Blank + Zip tas
  • Displays added projects from devfile
  • Samples content are provided from devfile
  • Avoid usage samples.json
  • Remove projects description

What issues does this PR fix or reference?

#13678
#13665

@ashumilova
Adapt project selector widget to manage projects from devfile
ab4ca9c 
Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
@ashumilova ashumilova added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/che7GA labels Jul 12, 2019
@ashumilova
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 12, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13825
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ashumilova ashumilova mentioned this pull request Jul 15, 2019
Closed
@monaka
Copy link
Member

monaka commented Jul 15, 2019

I cherry-picked it and checked on my instance. It works fine. cool.

rhopp
rhopp approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@rhopp rhopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... I've tried that too locally and LGTM.
crw-ci-e2e-happy-path-test failure is unrelated.

@ashumilova
Copy link
Contributor Author

@monaka and @rhopp thank you for trying and the feedbacks.

@ashumilova ashumilova merged commit 69e7929 into master Jul 15, 2019
@ashumilova ashumilova deleted the projects_widget branch July 15, 2019 12:35
This was referenced Jul 16, 2019
Closed
Closed
@ashumilova ashumilova mentioned this pull request Jul 17, 2019
Closed
@SkorikSergey SkorikSergey mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurinnoy akurinnoy akurinnoy approved these changes

@olexii4 olexii4 olexii4 approved these changes

@rhopp rhopp rhopp approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashumilova @che-bot @monaka @rhopp @olexii4 @akurinnoy