-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS-SELENIUM] Adapt WorkspaceCreationAndLsInitialization test according workspace creation from Dashboard changes #13885
[TS-SELENIUM] Adapt WorkspaceCreationAndLsInitialization test according workspace creation from Dashboard changes #13885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
@@ -45,7 +45,9 @@ suite('E2E', async () => { | |||
}); | |||
|
|||
test('Create and open workspace', async () => { | |||
await newWorkspace.createAndRunWorkspace(namespace, workspaceName, 'Java Maven', sampleName); | |||
await newWorkspace.typeWorkspaceName(workspaceName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, that instead of this change, we should change https://github.com/eclipse/che/blob/master/e2e/pageobjects/dashboard/NewWorkspace.ts#L192 (remove the logic of selecting sample)
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
What does this PR do?
According to workspace creation changes(#13825) we need to remove adding project to workspace from
WorkspaceCreationAndLsInitialization
test (it already added in devfile).