Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HappyPath] Make checking running application more stable #14284

Merged
merged 7 commits into from
Aug 20, 2019
Merged

[HappyPath] Make checking running application more stable #14284

merged 7 commits into from
Aug 20, 2019

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

This PR adds checking that application is ready to use before opening it in the Preview panel.

What issues does this PR fix or reference?

#13979

@SkorikSergey SkorikSergey added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/che-qe labels Aug 19, 2019
@Ohrimenko1988
Copy link
Contributor

CQ for axios 0.17.1 https://dev.eclipse.org/ipzilla/show_bug.cgi?id=15800

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@dmytro-ndp
Copy link
Contributor

@SkorikSergey : can you, please, take commit c732524 from master so that Happy path test could be run completely?

@dmytro-ndp
Copy link
Contributor

ci-build

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14284

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14284
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp
dmytro-ndp approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14284

@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14284
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

rhopp
rhopp reviewed Aug 20, 2019
View reviewed changes
e2e/pageobjects/ide/Ide.ts Outdated Show resolved Hide resolved
@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@SkorikSergey
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14284
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14284

@rhopp rhopp merged commit bbfae57 into master Aug 20, 2019
@che-bot che-bot added this to the 7.1.0 milestone Aug 20, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 20, 2019
@SkorikSergey SkorikSergey deleted the checkApplicationReadiness branch August 20, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@rhopp rhopp rhopp approved these changes

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SkorikSergey @Ohrimenko1988 @che-bot @dmytro-ndp @rhopp