Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ability to scroll for UD #14307

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Fix ability to scroll for UD #14307

merged 2 commits into from
Aug 22, 2019

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 22, 2019

What does this PR do?

Fix ability to scroll for UD. Fix styles. Improve che-list implementation.

What issues does this PR fix or reference?

#14211
#13236
#14256

Screenshot from 2019-08-22 12-48-41

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 changed the title Fix possibility to scroll for UD Fix ability to scroll for UD Aug 22, 2019
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 22, 2019
Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Google Chrome and Firefox on MacOS

@che-bot
Copy link
Contributor

che-bot commented Aug 22, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14307
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4 olexii4 merged commit 65058e4 into master Aug 22, 2019
@olexii4 olexii4 deleted the CHE-14211 branch August 22, 2019 12:45
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 22, 2019
@che-bot che-bot added this to the 7.1.0 milestone Aug 22, 2019
amisevsk added a commit to redhat-developer/rh-che that referenced this pull request Aug 28, 2019
Include fixes for
- UD scrolling
  - Upstream PR eclipse-che/che#14307
- Add 'target="_blank"' for make a wish button:
  - Upstream PR eclipse-che/che#14037

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Katka92 pushed a commit to Katka92/rh-che that referenced this pull request Sep 3, 2019
Include fixes for
- UD scrolling
  - Upstream PR eclipse-che/che#14307
- Add 'target="_blank"' for make a wish button:
  - Upstream PR eclipse-che/che#14037

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk pushed a commit to redhat-developer/rh-che that referenced this pull request Sep 6, 2019
Include fixes for
- UD scrolling
  - Upstream PR eclipse-che/che#14307
- Add 'target="_blank"' for make a wish button:
  - Upstream PR eclipse-che/che#14037

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk pushed a commit to redhat-developer/rh-che that referenced this pull request Sep 6, 2019
Include fixes for
- UD scrolling
  - Upstream PR eclipse-che/che#14307
- Add 'target="_blank"' for make a wish button:
  - Upstream PR eclipse-che/che#14037

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants