-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ability to scroll for UD #14307
Merged
Fix ability to scroll for UD #14307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
olexii4
requested review from
ashumilova,
benoitf,
l0rd,
nickboldt and
rhopp
as code owners
August 22, 2019 10:05
olexii4
changed the title
Fix possibility to scroll for UD
Fix ability to scroll for UD
Aug 22, 2019
che-bot
added
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
kind/bug
Outline of a bug - must adhere to the bug report template.
labels
Aug 22, 2019
akurinnoy
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Google Chrome and Firefox on MacOS
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
evidolob
approved these changes
Aug 22, 2019
che-bot
removed
the
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
label
Aug 22, 2019
amisevsk
added a commit
to redhat-developer/rh-che
that referenced
this pull request
Aug 28, 2019
Include fixes for - UD scrolling - Upstream PR eclipse-che/che#14307 - Add 'target="_blank"' for make a wish button: - Upstream PR eclipse-che/che#14037 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Katka92
pushed a commit
to Katka92/rh-che
that referenced
this pull request
Sep 3, 2019
Include fixes for - UD scrolling - Upstream PR eclipse-che/che#14307 - Add 'target="_blank"' for make a wish button: - Upstream PR eclipse-che/che#14037 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
pushed a commit
to redhat-developer/rh-che
that referenced
this pull request
Sep 6, 2019
Include fixes for - UD scrolling - Upstream PR eclipse-che/che#14307 - Add 'target="_blank"' for make a wish button: - Upstream PR eclipse-che/che#14037 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
pushed a commit
to redhat-developer/rh-che
that referenced
this pull request
Sep 6, 2019
Include fixes for - UD scrolling - Upstream PR eclipse-che/che#14307 - Add 'target="_blank"' for make a wish button: - Upstream PR eclipse-che/che#14037 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix ability to scroll for UD. Fix styles. Improve che-list implementation.
What issues does this PR fix or reference?
#14211
#13236
#14256