Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add small fixes for UD #14347

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Add small fixes for UD #14347

merged 1 commit into from
Sep 2, 2019

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 28, 2019 •
edited
Loading

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Add small fixes for UD. A list of fixes:

  • remove the URL query string when back to UD
  • remove unnecessary CHE6 message 'Starting workspace agent' from the factory page
  • add the rule for hiding navbar
  • code clean up for 'dashboard/src/app/ide/ide-iframe/ide-iframe.service.ts'
  • add the rule for opening navbar after the path changing
  • code clean up for 'dashboard/src/app/index.module.ts'
  • remove unused controller 'dashboard/src/app/navbar/navbar-selected.controller.ts'
  • remove navbar toggle which is unused.
  • fix rootscope interface

@olexii4 olexii4 requested a review from akurinnoy August 28, 2019 07:59
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 28, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@olexii4
small fixes
13ee593 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
Copy link
Contributor Author

olexii4 commented Aug 28, 2019 •
edited
Loading

ci-test

@olexii4
Copy link
Contributor Author

olexii4 commented Aug 28, 2019

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14347

@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14347

@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@gorkem
Copy link
Contributor

gorkem commented Aug 28, 2019

Is there a list of small fixes covered on this PR?

@olexii4
Copy link
Contributor Author

olexii4 commented Aug 29, 2019

@gorkem I have added a list of small fixes covered on this PR

akurinnoy
akurinnoy approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olexii4 Please provide a separate commit for each fix next time.

@olexii4
Copy link
Contributor Author

olexii4 commented Sep 2, 2019

@akurinnoy OK. I'll do

dmytro-ndp
dmytro-ndp approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests results look good.

@olexii4 olexii4 merged commit 3cc77bc into master Sep 2, 2019
@olexii4 olexii4 deleted the CHE-13875 branch September 2, 2019 10:28
@che-bot che-bot added this to the 7.1.0 milestone Sep 2, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurinnoy akurinnoy akurinnoy approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@ashumilova ashumilova Awaiting requested review from ashumilova

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@mmorhun mmorhun Awaiting requested review from mmorhun

@evidolob evidolob Awaiting requested review from evidolob

@SkorikSergey SkorikSergey Awaiting requested review from SkorikSergey

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@olexii4 @che-bot @gorkem @dmytro-ndp @AndrienkoAleksandr @akurinnoy