Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existed "che-e2e" image for using on CI #14351

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Conversation

Ohrimenko1988
Copy link
Contributor

Signed-off-by: Ihor Okhrimenko iokhrime@redhat.com

What does this PR do?

Update existed "che-e2e" image for using on CI

What issues does this PR fix or reference?

Issue: #14346

Release Notes

Docs PR

Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 28, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14351

@Ohrimenko1988
Copy link
Contributor Author

ci-build

@dmytro-ndp
Copy link
Contributor

Could you, please, push the image with fixup somewhere accessible form CRW Jenkins CI so that it was possible to check running of Happy path tests on fixed image on Jenkins CI?

@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@Ohrimenko1988
Copy link
Contributor Author

@dmytro-ndp Sorry, I can't do it now. If you really need to ensure that everything works as expected you may follow instruction and build it by your own
https://github.com/eclipse/che/blob/master/dockerfiles/e2e/README.md

@Ohrimenko1988
Copy link
Contributor Author

@dmytro-ndp you may try image bujhtr5555/che-e2e

@dmytro-ndp
Copy link
Contributor

@Ohrimenko1988: thanks

Copy link
Member

@ScrewTSW ScrewTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…iner

Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 29, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14351

Copy link
Contributor

@Katka92 Katka92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you've added mounting of local tests. Have you thought about adding the mount for screenshots too?

@Ohrimenko1988
Copy link
Contributor Author

@Katka92 Screenshots already included into mounted "e2e" folder

@che-bot
Copy link
Contributor

che-bot commented Aug 29, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@Ohrimenko1988 Ohrimenko1988 merged commit a6bab47 into master Aug 29, 2019
@Ohrimenko1988 Ohrimenko1988 deleted the selen-update-ci branch August 29, 2019 12:02
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 29, 2019
@che-bot che-bot added this to the 7.1.0 milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants