Do not apply proxy settings for JWTProxy container; #14448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
mshaposhnik
requested review from
amisevsk,
l0rd,
metlos,
nickboldt,
rhopp and
sleshchenko
as code owners
che-bot
added
status/code-review
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
sleshchenko
approved these changes
Sep 6, 2019
| .getPodsData() | ||
| .entrySet() | ||
| .stream() | ||
| .filter(entry -> !entry.getKey().equals(JWT_PROXY_POD_NAME)) |
There was a problem hiding this comment.
-
Please consider adding one like comment why here we ignore JWT_PROXY pod.
-
Please consider adding test case for this.
There was a problem hiding this comment.
Why i am always modifying classes which doesn;t have tests at all 🤣 ?
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
|
ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
ci-build |
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2217/) doesn't show any regression against this Pull Request. |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When workspace proxy is set, this setting applied to all containers of the workspace, including JWTProxy. So when JWTProxy tries to access the upstream endpoint (which is always in internal form, e.g.
http://servers7ggiqm3-che-machine-execs37:4444) it fails. This PR prevents of adding proxy settings to the JWTProxy containers, which is OK since JWTProxy never does any outbound requests.What issues does this PR fix or reference?
#14052
Release Notes
N/A
Docs PR
N/A