Plugin ephemeral volume feature for CheContainers

[AndrienkoAleksandr]

What does this PR do?

Plugin ephemeral volume feature for CheContainers

What issues does this PR fix or reference?

#13387
Depends on eclipse-che/che-plugin-broker#74

[che-bot]

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

• build details
• "che-server" docker image: maxura/che-server:14539
• test artifacts
• https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "crw-ci-test" to rerun the test.

[che-bot]

E2E tests of Eclipse Che Multiuser on OCP has been successful:

• Build details
• Test report
• docker image: eclipseche/che-server:14539

[nickboldt]

Not technically an install issue, but critical for productization. Need this implemented ASAP so release process can be adapted to use artifacts from this new approach.

[nickboldt]

I'm not clear on the technical details here so I can't approve. Must rely on people with more deep knowledge of the codebase.

[che-bot]

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

• build details
• "che-server" docker image: maxura/che-server:14539
• test artifacts
• https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "crw-ci-test" to rerun the test.

[che-bot]

E2E tests of Eclipse Che Multiuser on OCP has failed:

• Build details
• Test report
• docker image: eclipseche/che-server:14539
  https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "ci-test" to rerun the test.

[AndrienkoAleksandr]

Hello, guys, updated pr, latest changes seems without regression. Tested with common and unique pvc strategies.

[AndrienkoAleksandr]

I am worry about one thing. Pr depends on eclipse-che/che-plugin-broker#74 If use understood correctly, even if I merge both pr's, feature won't work until release, because we have hardcoded version https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L596 , and we don't have next or nigltly tag... @ibuziuk Should I set up version image tag with git hash, until release?

[che-bot]

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

• build details
• "che-server" docker image: maxura/che-server:14539
• test artifacts
• https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "crw-ci-test" to rerun the test.

[che-bot]

E2E tests of Eclipse Che Multiuser on OCP has failed:

• Build details
• Test report
• docker image: eclipseche/che-server:14539
  https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "ci-test" to rerun the test.

[che-bot]

E2E tests of Eclipse Che Multiuser on OCP has been successful:

• Build details
• Test report
• docker image: eclipseche/che-server:14539

[sleshchenko]

in general LGTM
Just a few minor comments.

And before approving it, I would like to play with your changes and test different cases by myself.
Will do soon

[che-bot]

E2E tests of Eclipse Che Multiuser on OCP has failed:

• Build details
• Test report
• docker image: eclipseche/che-server:14539
  https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "ci-test" to rerun the test.

[che-bot]

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

• build details
• "che-server" docker image: maxura/che-server:14539
• test artifacts
• https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "crw-ci-test" to rerun the test.

[che-bot]

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

• build details
• "che-server" docker image: maxura/che-server:14539
• test artifacts
• https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "crw-ci-test" to rerun the test.

[amisevsk]

LGTM apart from @sleshchenko's comments. Approving so that this PR can be merged once those are addressed.

Consider also updating default brokers to v0.21.0 to include the ephemeral support from eclipse-che/che-plugin-broker#74

[che-bot]

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

• build details
• "che-server" docker image: maxura/che-server:14539

[che-bot]

E2E tests of Eclipse Che Multiuser on OCP has failed:

• Build details
• Test report
• docker image: eclipseche/che-server:14539
  https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "ci-test" to rerun the test.

[che-bot]

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

• build details
• "che-server" docker image: maxura/che-server:14539

[sleshchenko]

Great job! 👍

[che-bot]

E2E tests of Eclipse Che Multiuser on OCP has failed:

• Build details
• Test report
• docker image: eclipseche/che-server:14539
  https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
  Use command "ci-test" to rerun the test.

[SkorikSergey]

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2431//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.