Implement workaround for Go to Definition feature HappyPath scenario #14570

musienko-maxim · 2019-09-17T09:45:43Z

What does this PR do?

Add new PageObject with methods for invocation context menu and command.
Add to the Editor PageObjects methods for clicking on a content in defined position (string and column), context clicking in defined position and calling Go to definition with mouse (move mouse to defined position and click with Control key)

What issues does this PR fix or reference?

#14522

@dmytro-ndp, @rhopp, @Katka92, @nickboldt, @l0rd - review pls.

che-bot · 2019-09-18T12:50:28Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14570

che-bot · 2019-09-18T13:26:31Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14570
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

Signed-off-by: musienko maksym <mmusiien@redhat.com>

che-bot · 2019-09-19T06:10:21Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14570

che-bot · 2019-09-19T13:52:41Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14570
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-09-19T13:58:00Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14570
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-09-19T14:03:30Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14570
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

e2e/pageobjects/ide/Editor.ts

dmytro-ndp · 2019-09-19T14:07:45Z

e2e/tests/e2e_happy_path/HappyPath.spec.ts

+            await editor.waitEditorAvailable(codeNavigationClassName);
+        }
+        catch (err) {
+            if (err instanceof error.TimeoutError) {


It would be clearer to have comment with link to issue.

Katka92 · 2019-09-20T05:47:30Z

@musienko-maxim Have you run the code with the changes you made? For me it seems like tslint should fix some formatting issue that appears in your last changes and I have problem building the code from that branch. I think that this could fix failed crw-ci-e2e-happy-path-tests too.

che-bot · 2019-09-20T06:40:52Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14570

musienko-maxim · 2019-09-20T07:03:13Z

@musienko-maxim Have you run the code with the changes you made? For me it seems like tslint should fix some formatting issue that appears in your last changes and I have problem building the code from that branch. I think that this could fix failed crw-ci-e2e-happy-path-tests too.

Fixed and tests relaunched

che-bot · 2019-09-20T07:12:11Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14570

Signed-off-by: musienko maksym <mmusiien@redhat.com>

musienko-maxim

che-bot · 2019-09-20T12:22:59Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14570

che-bot · 2019-09-20T12:33:52Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14570

che-bot · 2019-09-20T12:51:57Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14570

dmytro-ndp · 2019-09-20T13:18:31Z

ci-build

che-bot · 2019-09-20T17:19:13Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14570

che-bot · 2019-09-20T17:30:07Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14570

che-bot · 2019-09-20T17:51:11Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14570
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

dmytro-ndp

@musienko-maxim: I would appreciate it if you will take into account ALL my remaining notices.

che-bot · 2019-09-22T14:18:06Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14570

che-bot · 2019-09-22T14:50:57Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14570

musienko-maxim requested review from l0rd, nickboldt, Ohrimenko1988 and rhopp as code owners September 17, 2019 09:45

musienko-maxim changed the title ~~Implement workaround for Go to Definition feature HappyPath scenario~~ [WIP] Implement workaround for Go to Definition feature HappyPath scenario Sep 17, 2019

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 17, 2019

implement workaround for Go to symbol feature

dadb74b

Signed-off-by: musienko maksym <mmusiien@redhat.com>

musienko-maxim force-pushed the che#14522 branch from 354b4c8 to dadb74b Compare September 19, 2019 06:01

eclipse-che deleted a comment from che-bot Sep 19, 2019

dmytro-ndp reviewed Sep 19, 2019

View reviewed changes

e2e/pageobjects/ide/Editor.ts Outdated Show resolved Hide resolved

dmytro-ndp reviewed Sep 19, 2019

View reviewed changes

apply new formatting, correct mistakes

2d4a1d4

musienko-maxim added 2 commits September 20, 2019 15:06

Merge branch 'master' into che#14522

c6bf827

merge with master

5b45a7a

Signed-off-by: musienko maksym <mmusiien@redhat.com>

musienko-maxim commented Sep 20, 2019

View reviewed changes

musienko-maxim added 2 commits September 20, 2019 20:07

remove redundant line

557d787

add empty lines

dd2f6f8

dmytro-ndp approved these changes Sep 20, 2019

View reviewed changes

Apply correct formatting

e74332e

musienko-maxim merged commit d79cab2 into master Sep 22, 2019

musienko-maxim deleted the che#14522 branch September 22, 2019 15:23

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 22, 2019

che-bot added this to the 7.2.0 milestone Sep 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement workaround for Go to Definition feature HappyPath scenario #14570

Implement workaround for Go to Definition feature HappyPath scenario #14570

musienko-maxim commented Sep 17, 2019 •

edited

Loading

che-bot commented Sep 18, 2019

che-bot commented Sep 18, 2019

che-bot commented Sep 19, 2019

che-bot commented Sep 19, 2019

che-bot commented Sep 19, 2019

che-bot commented Sep 19, 2019

dmytro-ndp Sep 19, 2019 •

edited

Loading

Katka92 commented Sep 20, 2019

che-bot commented Sep 20, 2019

musienko-maxim commented Sep 20, 2019

che-bot commented Sep 20, 2019

musienko-maxim left a comment

che-bot commented Sep 20, 2019

che-bot commented Sep 20, 2019

che-bot commented Sep 20, 2019

dmytro-ndp commented Sep 20, 2019

che-bot commented Sep 20, 2019

che-bot commented Sep 20, 2019

che-bot commented Sep 20, 2019

dmytro-ndp left a comment

che-bot commented Sep 22, 2019

che-bot commented Sep 22, 2019

Implement workaround for Go to Definition feature HappyPath scenario #14570

Implement workaround for Go to Definition feature HappyPath scenario #14570

Conversation

musienko-maxim commented Sep 17, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

che-bot commented Sep 18, 2019

che-bot commented Sep 18, 2019

che-bot commented Sep 19, 2019

che-bot commented Sep 19, 2019

che-bot commented Sep 19, 2019

che-bot commented Sep 19, 2019

dmytro-ndp Sep 19, 2019 • edited Loading

Choose a reason for hiding this comment

Katka92 commented Sep 20, 2019

che-bot commented Sep 20, 2019

musienko-maxim commented Sep 20, 2019

che-bot commented Sep 20, 2019

musienko-maxim left a comment

Choose a reason for hiding this comment

che-bot commented Sep 20, 2019

che-bot commented Sep 20, 2019

che-bot commented Sep 20, 2019

dmytro-ndp commented Sep 20, 2019

che-bot commented Sep 20, 2019

che-bot commented Sep 20, 2019

che-bot commented Sep 20, 2019

dmytro-ndp left a comment

Choose a reason for hiding this comment

che-bot commented Sep 22, 2019

che-bot commented Sep 22, 2019

musienko-maxim commented Sep 17, 2019 •

edited

Loading

dmytro-ndp Sep 19, 2019 •

edited

Loading