replace sed delimiters to be able to use / in docker image buildscript #14572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparkoo
requested review from
benoitf,
l0rd,
nickboldt and
rhopp
as code owners
benoitf
approved these changes
Sep 17, 2019
|
👍 |
che-bot
added
the
status/code-review
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces
seddelimiters in docker image build script. It will be now possible to use/in it's params. It has no effect to current behavior.I use it like this
sh -x build.sh --organization:quay.io/mvala --prefix:che --name:server --tag:feature1 --dockerfile:Dockerfileto build my customquay.io/mvala/che-server:feature1image.What issues does this PR fix or reference?
n/a