Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix security vulnerability and Dashboard's workspace detail page #14644

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Fix security vulnerability and Dashboard's workspace detail page #14644

merged 2 commits into from
Sep 26, 2019

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Sep 24, 2019 •
edited
Loading

What does this PR do?

  • [Dashboard] activate first tab on workspace details page if no other tab was enabled in query params
  • [e2e tests] update axios version to avoid security vulnerability

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Sep 24, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 24, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@benoitf
Copy link
Contributor

benoitf commented Sep 24, 2019

@akurinnoy do you have CQ ?

@SkorikSergey
Copy link
Contributor

ci-build

@che-bot
Copy link
Contributor

che-bot commented Sep 24, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@akurinnoy
Copy link
Contributor Author

@benoitf
yes, it was done by @evidolob a month ago https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20719

@akurinnoy
activate first tab on workspace detals page if no query params were p…
79e8bc1 
…assed

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
update axios version to fix high security vulnerability
9fd2c41 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 25, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@dmytro-ndp
Copy link
Contributor

ci-build

@che-bot
Copy link
Contributor

che-bot commented Sep 25, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 25, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14644

@SkorikSergey
Copy link
Contributor

ci-test

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2424//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@che-bot
Copy link
Contributor

che-bot commented Sep 25, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy akurinnoy merged commit ece3257 into master Sep 26, 2019
@akurinnoy akurinnoy deleted the fixes branch September 26, 2019 08:03
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
@akurinnoy
Fix security vulnerability and Dashboard's workspace detail page (#14644
a7e52e9 
)

* activate first tab on workspace detals page if no query params were passed

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* update axios version to fix high security vulnerability

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@olexii4 olexii4 olexii4 approved these changes

@benoitf benoitf benoitf approved these changes

@SkorikSergey SkorikSergey Awaiting requested review from SkorikSergey

@ashumilova ashumilova Awaiting requested review from ashumilova

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@akurinnoy @che-bot @benoitf @SkorikSergey @dmytro-ndp @olexii4 @Ohrimenko1988