Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deployments yamls in helm charts to be compatible with k8s v1.16 #14700

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Sep 27, 2019

What does this PR do?

Update Helm charts deployments yamls because otherwise Che deployment fails on latest
version of Kubernetes.

What issues does this PR fix or reference?

#14697

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Sep 27, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14700

@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you test if on K8s < v1.16
Are these changes compatible?

@l0rd
Copy link
Contributor Author

l0rd commented Sep 30, 2019

ci-test

@l0rd
Copy link
Contributor Author

l0rd commented Sep 30, 2019

@sleshchenko Deployment resource has been promoted to stable and moved to apps/v1 in 1.9 (december 2017).

But Che already requires k8s v1.8 or earlier because both registries deployment.yaml use apps/v1.

cc @rkratky @themr0c: I haven't see it in the doc but the minimum required version of Kubernetes should be 1.9.

cc @slemeur

@che-bot
Copy link
Contributor

che-bot commented Sep 30, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@l0rd
Copy link
Contributor Author

l0rd commented Oct 1, 2019

@eclipse/eclipse-che-qa can you please review why PR check is failing?

@dmytro-ndp
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 3, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@l0rd l0rd merged commit a684d21 into eclipse-che:master Oct 3, 2019
@l0rd l0rd deleted the k8s-1.16-deployment branch October 3, 2019 10:18
@che-bot che-bot added this to the 7.3.0 milestone Oct 3, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 3, 2019
@Kenzim
Copy link

Kenzim commented Oct 6, 2019

now that this has been merged, is there anything else i have to do? i have been trying to deploy this for a few days using the kubernetes tutorial but to no avail. i keep getting this error. any help would be greatly appreciated. thanks

@l0rd
Copy link
Contributor Author

l0rd commented Oct 6, 2019

@Kenzim that's available in the nightly build not in the latest stable version of Che yet. Can you be more precise about how you are trying to deploy Che?

@Kenzim
Copy link

Kenzim commented Oct 6, 2019 via email

@l0rd
Copy link
Contributor Author

l0rd commented Oct 6, 2019

You can try to use chectl next channel instead of stable one:

chectl update next

If that doesn't work please open an issue of type bug providing all the informations required in the bug form that will help us to analyse your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants