-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Deployments yamls in helm charts to be compatible with k8s v1.16 #14700
Conversation
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you test if on K8s < v1.16
Are these changes compatible?
ci-test |
@sleshchenko Deployment resource has been promoted to But Che already requires k8s v1.8 or earlier because both registries deployment.yaml use cc @rkratky @themr0c: I haven't see it in the doc but the minimum required version of Kubernetes should be 1.9. cc @slemeur |
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
@eclipse/eclipse-che-qa can you please review why PR check is failing? |
ci-test |
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
now that this has been merged, is there anything else i have to do? i have been trying to deploy this for a few days using the kubernetes tutorial but to no avail. i keep getting this error. any help would be greatly appreciated. thanks |
@Kenzim that's available in the nightly build not in the latest stable version of Che yet. Can you be more precise about how you are trying to deploy Che? |
I just followed kubernetes tutorial, installed on a ubuntu vps, installed
helm tiller all that, and then am using chectl to start multi user instance.
thanks for reply.
…On Sun, Oct 6, 2019 at 5:48 PM Mario Loriedo ***@***.***> wrote:
@Kenzim <https://github.com/Kenzim> that's available in the nightly build
not in the latest stable version of Che yet. Can you be more precise about
how you are trying to deploy Che?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14700>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKW5QU5QKEIXLX3OVI4A5CLQNIJFDANCNFSM4I3JT47Q>
.
|
You can try to use chectl
If that doesn't work please open an issue of type |
What does this PR do?
Update Helm charts deployments yamls because otherwise Che deployment fails on latest
version of Kubernetes.
What issues does this PR fix or reference?
#14697