Show the warning message in the case with deprecated plugins #14707

olexii4 · 2019-09-29T01:25:36Z

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Add implementation of the warning message in the case with deprecated plugins and the possibility to auto-migrate plugins by pressing the button.

What issues does this PR fix or reference?

Needed for #13021

Release Notes

show a warning message in the case with deprecated editor or plugins.
add a possibility to migrate by pressing the button.

Docs PR

https://youtu.be/7U00YxALrFE

olexii4 · 2019-09-29T01:26:14Z

@slemeur WDYT?

che-bot · 2019-09-29T01:37:59Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14707

che-bot · 2019-09-29T02:17:03Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14707
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

olexii4 · 2019-09-29T07:45:59Z

ci-test

che-bot · 2019-09-29T08:34:41Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14707
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

slemeur · 2019-10-01T12:25:23Z

Is it migrating or upgrading ?

olexii4 · 2019-10-01T14:03:20Z

I think it could be an upgrading in the case when we just upgrade the version of the same plugin. But it can be a migration too.

amisevsk

Just to double-check, does the warning only appear on the Plugins tab, or whenever workspace details are opened?

olexii4 · 2019-10-01T14:32:31Z

@amisevsk The warning only appears on the Plugins tab.

amisevsk · 2019-10-01T15:18:34Z

The warning only appears on the Plugins tab.

I think I understand why that is the case, but also worry that a user might never see it (I don't know how often a user would visit the plugins/editors tab for an already set up workspace).

+1 on the changes, regardless.

olexii4 · 2019-10-03T17:47:37Z

I have updated

https://youtu.be/qkjxKXLGZ70

olexii4 · 2019-10-03T17:48:33Z

@slemeur, @amisevsk WDYT?

slemeur · 2019-10-04T12:07:20Z

Based on the video shared here: https://www.youtube.com/watch?v=qkjxKXLGZ70&feature=youtu.be

The workspace includes deprecated plugins. Migrate deprecated plugins by pressing the button Migrate plugins.

The workspace uses deprecated plugins. Upgrade the plugins to their latest version by pressing the button Upgrade plugins.

This plugin is deprecated. Migrate to the next .... version by pressing the icon

This is unclear. Which icon user has to press? It's a warning icon, a user will not expect to be able to click on it to fix the problem. I would remove the action from the button, and just explain what to do.
Message: "This plugin is deprecated. Select a newer version in the dropdown list or press "Upgrade plugins" to upgrade all plugins to their latest version".

For editors

The error message mention "Migrate plugins", but the button is not there.
Should the button be "Upgrade deprecated components"?

The workspace includes deprecated plugins and editors. Migrate deprecated plugins by pressing the button Migrate plugins.

The workspace uses deprecated plugins and editor. Upgrade to the latest versions available by pressing the button Upgrade plugins.

This workspace includes the deprecated editor
This workspaces uses a deprecated editor.

I find the experience a bit challenging and confusing for a end-user. Should the action be closer to the error message? Could you have "Click Here to upgrade all deprecated components" at the end of the error message, which will trigger the action ?

cc @evidolob .

che-bot · 2019-10-07T17:09:22Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
logs and configs
"che-server" docker image: maxura/che-server:14707

olexii4 · 2019-10-07T17:13:38Z

@slemeur Is it ok for you?

che-bot · 2019-10-07T17:56:06Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14707

dashboard/src/app/workspaces/workspace-details/workspace-details.service.spec.ts

...board/src/app/workspaces/workspace-details/workspace-plugins/workspace-plugins.controller.ts

dashboard/src/components/api/workspace/che-workspace.factory.ts

dashboard/yarn.lock

che-bot · 2019-10-08T13:29:57Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
logs and configs
"che-server" docker image: maxura/che-server:14707

Signed-off-by: Oleksii Orel <oorel@redhat.com>

che-bot · 2019-10-08T13:52:17Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
logs and configs
"che-server" docker image: maxura/che-server:14707

akurinnoy

Thanks! Nice work, Oleksii!

che-bot · 2019-10-08T14:31:42Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14707
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

olexii4 requested review from evidolob, slemeur, vitaliy-guliy, AndrienkoAleksandr, mmorhun and akurinnoy September 29, 2019 01:25

olexii4 requested review from ashumilova, benoitf, l0rd, nickboldt and rhopp as code owners September 29, 2019 01:25

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Sep 29, 2019

mmorhun approved these changes Sep 30, 2019

View reviewed changes

benoitf approved these changes Sep 30, 2019

View reviewed changes

AndrienkoAleksandr approved these changes Sep 30, 2019

View reviewed changes

vitaliy-guliy approved these changes Sep 30, 2019

View reviewed changes

amisevsk reviewed Oct 1, 2019

View reviewed changes

eclipse-che deleted a comment from che-bot Oct 7, 2019

olexii4 force-pushed the CHE-13021 branch from e3eccee to cb5fe8a Compare October 7, 2019 16:56

eclipse-che deleted a comment from che-bot Oct 7, 2019

olexii4 mentioned this pull request Oct 7, 2019

Project delete button in dashboard is invisible #14773

Closed

akurinnoy reviewed Oct 8, 2019

View reviewed changes

olexii4 force-pushed the CHE-13021 branch from cb5fe8a to 8ac84da Compare October 8, 2019 13:16

show the warning message in the case with deprecated plugins

b57d104

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the CHE-13021 branch from 8ac84da to b57d104 Compare October 8, 2019 13:40

akurinnoy approved these changes Oct 8, 2019

View reviewed changes

evidolob approved these changes Oct 8, 2019

View reviewed changes

olexii4 merged commit 70d0933 into master Oct 8, 2019

olexii4 deleted the CHE-13021 branch October 8, 2019 14:32

che-bot added this to the 7.3.0 milestone Oct 8, 2019

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show the warning message in the case with deprecated plugins #14707

Show the warning message in the case with deprecated plugins #14707

olexii4 commented Sep 29, 2019 •

edited

Loading

olexii4 commented Sep 29, 2019

che-bot commented Sep 29, 2019

che-bot commented Sep 29, 2019

olexii4 commented Sep 29, 2019

che-bot commented Sep 29, 2019

slemeur commented Oct 1, 2019

olexii4 commented Oct 1, 2019

amisevsk left a comment

olexii4 commented Oct 1, 2019

amisevsk commented Oct 1, 2019

olexii4 commented Oct 3, 2019

olexii4 commented Oct 3, 2019

slemeur commented Oct 4, 2019 •

edited

Loading

che-bot commented Oct 7, 2019

olexii4 commented Oct 7, 2019

che-bot commented Oct 7, 2019

che-bot commented Oct 8, 2019

che-bot commented Oct 8, 2019

akurinnoy left a comment

che-bot commented Oct 8, 2019

Show the warning message in the case with deprecated plugins #14707

Show the warning message in the case with deprecated plugins #14707

Conversation

olexii4 commented Sep 29, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

olexii4 commented Sep 29, 2019

che-bot commented Sep 29, 2019

che-bot commented Sep 29, 2019

olexii4 commented Sep 29, 2019

che-bot commented Sep 29, 2019

slemeur commented Oct 1, 2019

olexii4 commented Oct 1, 2019

amisevsk left a comment

Choose a reason for hiding this comment

olexii4 commented Oct 1, 2019

amisevsk commented Oct 1, 2019

olexii4 commented Oct 3, 2019

olexii4 commented Oct 3, 2019

slemeur commented Oct 4, 2019 • edited Loading

che-bot commented Oct 7, 2019

olexii4 commented Oct 7, 2019

che-bot commented Oct 7, 2019

che-bot commented Oct 8, 2019

che-bot commented Oct 8, 2019

akurinnoy left a comment

Choose a reason for hiding this comment

che-bot commented Oct 8, 2019

olexii4 commented Sep 29, 2019 •

edited

Loading

slemeur commented Oct 4, 2019 •

edited

Loading