Devfile validation via message entity provider #14740

mshaposhnik · 2019-10-02T08:37:34Z

What does this PR do?

Makes devfile parsing into DTO in entity provider to the REST endpoint can accept the DTO object, not string.
Makes validation of the devfile inside workspace before actual parsing into DTO.

What issues does this PR fix or reference?

#13526

Release Notes

N/A

Docs PR

N/A

che-bot · 2019-10-02T08:38:54Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14740
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

...e-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/JavaxExceptionMapper.java

che-bot · 2019-10-02T08:45:28Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

sleshchenko

In general - looks good to me

che-bot · 2019-10-02T13:21:55Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14740
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-02T13:22:56Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2019-10-02T13:32:02Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14740
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-02T13:35:45Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2019-10-02T14:04:45Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14740
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-02T14:16:18Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14740
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-02T14:55:57Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2019-10-03T07:08:08Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14740
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-03T07:29:32Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14740
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-03T08:10:58Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2019-10-03T11:25:22Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

metlos

Generally looks OK, but the inability to accept YAML in the REST endpoint looks like an unacceptable regression to me...

...-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceService.java

sleshchenko

LGTM
but make sure you addressed Lukas' PR before merging.

che-bot · 2019-10-04T01:33:07Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14740
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-04T02:16:17Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

metlos

Good job!

mshaposhnik · 2019-10-04T07:55:03Z

ci-test

mshaposhnik · 2019-10-04T07:55:10Z

crw-ci-test

che-bot · 2019-10-04T08:14:18Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14740
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

SkorikSergey · 2019-10-04T08:43:32Z

According to selenium tests results there is error notification(see screenshot) when rename workspace with RUNNING status.

Screenshot

Screencast

che-bot · 2019-10-04T08:50:41Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

mshaposhnik · 2019-10-04T09:04:44Z

Ok i see. This is a know bug i created a day ago: #14739

che-bot · 2019-10-08T07:58:28Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
logs and configs
"che-server" docker image: maxura/che-server:14740

che-bot · 2019-10-08T08:43:17Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

mshaposhnik · 2019-10-08T09:05:21Z

ci-test

che-bot · 2019-10-08T09:16:08Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

mshaposhnik · 2019-10-08T09:23:48Z

ci-test

che-bot · 2019-10-08T09:24:33Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

mshaposhnik · 2019-10-08T10:58:51Z

ci-test

che-bot · 2019-10-08T11:03:48Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14740
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

Devfile validation via message body reader;

8d3c27e

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Oct 2, 2019

mshaposhnik commented Oct 2, 2019

View reviewed changes

...e-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/JavaxExceptionMapper.java Outdated Show resolved Hide resolved

benoitf changed the title ~~Devfile validation via message entiry provider;~~ Devfile validation via message entity provider Oct 2, 2019

sleshchenko reviewed Oct 2, 2019

View reviewed changes

mshaposhnik added 2 commits October 2, 2019 16:19

Prepare for review fixes

86c3e7e

Prepare for review fixes

a634bdd

Fix fmt

011ba36

Fix fmt

4d07aa8

Fix fmt

93e02a2

Add some javadocs

0d1da70

Remove beta annotation

6bb4546

mshaposhnik added 2 commits October 3, 2019 11:57

Add some tests for entity readers

2d10ea8

fixup! Add some tests for entity readers

19d769b

mshaposhnik marked this pull request as ready for review October 3, 2019 09:01

mshaposhnik requested review from l0rd and metlos as code owners October 3, 2019 09:01

metlos reviewed Oct 3, 2019

View reviewed changes

...-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceService.java Outdated Show resolved Hide resolved

sleshchenko approved these changes Oct 3, 2019

View reviewed changes

Revert header value

5b19b64

metlos approved these changes Oct 4, 2019

View reviewed changes

Merge branch 'master' into validate_2

eef0241

musienko-maxim self-requested a review October 8, 2019 11:03

musienko-maxim approved these changes Oct 8, 2019

View reviewed changes

sparkoo approved these changes Oct 8, 2019

View reviewed changes

mshaposhnik merged commit fc531ea into master Oct 8, 2019

mshaposhnik deleted the validate_2 branch October 8, 2019 11:10

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 8, 2019

che-bot added this to the 7.3.0 milestone Oct 8, 2019

mshaposhnik restored the validate_2 branch October 8, 2019 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Devfile validation via message entity provider #14740

Devfile validation via message entity provider #14740

mshaposhnik commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

sleshchenko left a comment

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 3, 2019

che-bot commented Oct 3, 2019

che-bot commented Oct 3, 2019

che-bot commented Oct 3, 2019

metlos left a comment

sleshchenko left a comment

che-bot commented Oct 4, 2019

che-bot commented Oct 4, 2019

metlos left a comment

mshaposhnik commented Oct 4, 2019

mshaposhnik commented Oct 4, 2019

che-bot commented Oct 4, 2019

SkorikSergey commented Oct 4, 2019 •

edited

Loading

che-bot commented Oct 4, 2019

mshaposhnik commented Oct 4, 2019

che-bot commented Oct 8, 2019

che-bot commented Oct 8, 2019

mshaposhnik commented Oct 8, 2019

che-bot commented Oct 8, 2019

mshaposhnik commented Oct 8, 2019

che-bot commented Oct 8, 2019

mshaposhnik commented Oct 8, 2019

che-bot commented Oct 8, 2019

Devfile validation via message entity provider #14740

Devfile validation via message entity provider #14740

Conversation

mshaposhnik commented Oct 2, 2019

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

sleshchenko left a comment

Choose a reason for hiding this comment

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 2, 2019

che-bot commented Oct 3, 2019

che-bot commented Oct 3, 2019

che-bot commented Oct 3, 2019

che-bot commented Oct 3, 2019

metlos left a comment

Choose a reason for hiding this comment

sleshchenko left a comment

Choose a reason for hiding this comment

che-bot commented Oct 4, 2019

che-bot commented Oct 4, 2019

metlos left a comment

Choose a reason for hiding this comment

mshaposhnik commented Oct 4, 2019

mshaposhnik commented Oct 4, 2019

che-bot commented Oct 4, 2019

SkorikSergey commented Oct 4, 2019 • edited Loading

che-bot commented Oct 4, 2019

mshaposhnik commented Oct 4, 2019

che-bot commented Oct 8, 2019

che-bot commented Oct 8, 2019

mshaposhnik commented Oct 8, 2019

che-bot commented Oct 8, 2019

mshaposhnik commented Oct 8, 2019

che-bot commented Oct 8, 2019

mshaposhnik commented Oct 8, 2019

che-bot commented Oct 8, 2019

SkorikSergey commented Oct 4, 2019 •

edited

Loading