[regression] Fix provisioning volume for ephemeral-mode workspaces. #14768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
added
the
severity/blocker
amisevsk
requested review from
l0rd,
metlos,
nickboldt and
rhopp
as code owners
1 task
che-bot
added
status/code-review
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
AndrienkoAleksandr
approved these changes
Oct 4, 2019
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
@amisevsk: E2E tests hasn't shown regression. |
dmytro-ndp
approved these changes
Oct 4, 2019
|
@amisevsk: there is fixup of Happy path tests in master branch. You can take that changes an rerun the tests. |
Commit dd47af6 changes the way that certain volumes are handled; rather than storing the volume information in the relevant container's machine, it is stored in the environment's pods directly. To accomodate this, the EphemeralWorkspaceAdapter needs to pull the list of PVCs it provisions from the environment rather than machines. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
eph-workspace-fix
branch
from
cfc262c to
44ef65f
Compare
|
Thanks @dmytro-ndp |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes provisioning of volumes for ephemeral workspaces (#14749).
It also brings the
EphemeralWorkspaceAdaptermore in line withUniqueWorkspacePVCProvisioner, which I think is an overall good change.Background
PR #14539 modified the way that certain volumes are stored in the environment: it removed adding plugin volumes to the plugin's corresponding machine and instead placed them in the pod's container directly in order to support ephemeral mode volumes for workspace plugins. This means that the
pluginsvolume added for every sidecar is no longer in the machine and instead attached to each container.The
EphemeralWorkspaceAdapterwas working off a previous assumption -- that all workspace volumes could be found in the list of machines in the environment -- and used that fact to reconcile workspace volumes (for each volume in machine, update the corresponding pod to use emptyDir). This meant that thepluginsvolume was not being provisioned at all (and thus had no subpath assigned).This PR changes
EphemeralWorkspaceAdapterto be more in line withUniqueWorkspacePVCProvisioner, basically doing the same thing and then converting all PVCs to EmptyDir volumes.What issues does this PR fix or reference?
#14749