Serialize/deseialize list of DTO using same mechanism as single DTO object #14792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
l0rd,
metlos,
nickboldt,
rhopp,
skabashnyuk and
sleshchenko
as code owners
che-bot
added
status/code-review
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
skabashnyuk
approved these changes
Oct 7, 2019
sleshchenko
approved these changes
Oct 8, 2019
che-bot
removed
the
status/code-review
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Different ways of serialization/deserialization of the single and list of
DTOmay provide erroneous effects, when, for example, Gson type adapters is applied when single DTO is requested, and not applied when list is requested, so the same objects have different representation. This PR corrects situation for DTO lists.What issues does this PR fix or reference?
#14739
Release Notes
N/A
Docs PR
N/A